Repository navigation
Fix "Edit all columns" menu - #7218
Merged
Merged
Conversation
github-actions
Bot
added
Type: Bug
wetneb
added a commit
that referenced
this pull request
Mar 26, 2025
* fix: Application of transforms to all columns with undone operations Fixes #7212. * Add Cypress test * Fix Cypress test name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7212.
It turns out that all actions in the "All" -> "Edit all columns" menu didn't work if there were undone operations in the history, a bug caused by my introduction of the history erasure confirmation dialog.
This fixes it by simplifying the way those actions are implemented, making a single request to execute all operations on selected columns at once.
I intend to backport this to 3.9, to be released in 3.9.2.