🔴 Live TV: NVIDIA NeMo/Gym/pull/

vadam5 · 2026-03-11T03:11:41Z

Replacement PR for: #662
Contributors: @lbliii

first pass at guidelines for AI-enabled contributions. Open to all ideas/suggestions.

Signed-off-by: Lawrence Lane <llane@nvidia.com>

jmabry

Documentation appears in triplicate. Possible to reference a single-source of truth so that is more DRY in any secondary docs?

cmunley1 · 2026-04-16T23:18:18Z

can we update the DCO fix instructions regarding force push too?

…pates Signed-off-by: Lawrence Lane <llane@nvidia.com>

- Single-source the 'Use of AI and LLM Tools' section in the Fern development-setup page; CONTRIBUTING.md and the contribute index now carry the guiding principle plus a link instead of duplicating it (DRY). - Recommend tracking worthwhile drive-by changes as their own issue. - Add a PR template with an AI-assistance disclosure section and point attribution guidance at it (commit trailer kept as an alternative). - Reframe 'What We Will Close' as 'When We Request Changes' (close only if unaddressed). - Document force-push (--force-with-lease) when fixing DCO sign-off on an already-pushed branch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Lawrence Lane <llane@nvidia.com>

copy-pr-bot · 2026-06-16T17:23:17Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

lbliii · 2026-06-16T17:23:45Z

Thanks for the reviews — addressed all the feedback in ddd270a9 (the branch is now merged up to main).

Note on scope: this branch predated the Fern docs migration, so it was editing the old docs/contribute/*.md tree (since deleted on main, which is why it showed conflicts). I merged main in and the content now lives in the Fern pages under fern/versions/latest/pages/contribute/.

Changes:

DRY / triplicate (@jmabry): the full "Use of AI and LLM Tools" section now lives in one place — the Fern development-setup page. CONTRIBUTING.md and the contribute index keep just the guiding principle and link to it.
Drive-by edits as an issue (@jmabry): noted in the "Keep PRs focused" bullet.
PR template (@jmabry): added .github/PULL_REQUEST_TEMPLATE.md with an AI-assistance disclosure section; attribution guidance points there first.
Request changes vs close (@cmunley1): section is now "When We Request Changes"; close only if feedback is unaddressed.
DCO fix + force push (@cmunley1): the DCO-fix troubleshooting now documents git push --force-with-lease after an amend/rebase rewrites already-pushed history.

fern check passes (0 errors).

github-actions · 2026-06-16T17:24:25Z

🌿 Preview your docs: https://nvidia-preview-llane-contributing-udpates.docs.buildwithfern.com/nemo/gym

Here are the markdown pages you've updated:

jmabry

LG%C

Co-authored-by: JOSHUA MABRY <mabryjn@gmail.com> Signed-off-by: Seph Mard <seph.mard@gmail.com>

Remove PR-template AI disclosure and the attribution section, point agents at AGENTS.md, clarify main.yml nav edits, and separate NVIDIA Slack from external Fern org access requests. Signed-off-by: Seph Mard <smard@nvidia.com>

Signed-off-by: Seph Mard <smard@nvidia.com>

Make DCO -s required and cryptographic signing optional, point the quality bar at AGENTS.md, clarify Fern org access requests and Makefile login for externals, and allow N/A on the PR tests checklist. Signed-off-by: Seph Mard <smard@nvidia.com>

sephmard · 2026-08-11T17:45:41Z

/claude review

claude · 2026-08-11T17:48:23Z

SHIP — LGTM, no reliability concerns.

Docs/metadata-only change (7 files: PR template, AGENTS.md, CONTRIBUTING.md, Makefile echo text, fern/README.md, two MDX pages). No code, verifier, async, config, or public-API surface touched — nothing that can corrupt scores or hang a run.

The substantive change is a policy shift: cryptographic commit signing (-S) moves from required to optional, with DCO sign-off (-s) remaining the enforced bar. That's applied consistently across CONTRIBUTING.md, contribute/index.mdx, and development-setup.mdx, and the workflow example is updated to drop -S. Internally consistent and correct.

Note (author's call, non-blocking): this relaxes an existing convention — CLAUDE.md still states "All commits require DCO sign-off (-s) and cryptographic signature (-S)." Worth aligning CLAUDE.md in a follow-up so the repo has one source of truth.

jmabry

AGENTS.md and Claude.md will be out of sync now. Need something akin to

my-ai-library/
├── AGENTS.md                  # Unified root instructions (Codex, Claude, Copilot)
├── CLAUDE.md                  # Claude-specific rules or symlink to AGENTS.md
...

Merge former CLAUDE.md content into AGENTS.md (DCO -s only; -S optional) and turn CLAUDE.md into a symlink so Claude Code and other tools stay in sync. Signed-off-by: Seph Mard <smard@nvidia.com>

sephmard · 2026-08-11T18:11:49Z

@jmabry Addressed the AGENTS.md / CLAUDE.md sync concern:

AGENTS.md is now the unified root instructions (quality bar + former CLAUDE.md architecture/patterns)
CLAUDE.md is a symlink to AGENTS.md
Dropped the stale “-S required” line so it matches DCO-only CI (-S optional)

jmabry

LGTM

cmunley1 · 2026-08-11T18:27:59Z

+
+1. **Dataset** — JSONL with one task per row. NeMo Gym uses the OpenAI Responses API as its native format because it natively represents multi-turn, tool-calling agentic trajectories without custom serialization. Each row has `responses_create_params.input` (the input messages in Responses API format) and `verifier_metadata` (task-specific data passed to the verifier)
+2. **Resources Server** — implements verification logic, environment-specific tools, and per-task state isolation
+3. **Agent Harness** — reuse a built-in agent harness (e.g. OpenHands) or bring your own


feels we should mention multi agent somewhere - eg user simulation etc - but fine for another time

cmunley1 · 2026-08-11T18:28:56Z

+pre-commit install
+
+# Run servers
+gym env start \


should prob include rollouts, and setting env.yaml

lbliii added 7 commits February 9, 2026 12:53

contributing guide updates

54cf937

Signed-off-by: Lawrence Lane <llane@nvidia.com>

Merge branch 'main' into llane/contributing-udpates

b411ab8

add verbiage to docs

7aa4964

Signed-off-by: Lawrence Lane <llane@nvidia.com>

Merge branch 'main' into llane/contributing-udpates

a420d51

Merge branch 'main' into llane/contributing-udpates

7cd4fa1

Merge branch 'main' into llane/contributing-udpates

ed19cac

Merge branch 'main' into llane/contributing-udpates

8254335

vadam5 mentioned this pull request Mar 11, 2026

contributing guide updates #662

Closed

jmabry reviewed Mar 12, 2026

View reviewed changes

Comment thread docs/contribute/development-setup.md Resolved

jmabry requested changes Mar 12, 2026

View reviewed changes

Comment thread fern/versions/latest/pages/contribute/development-setup.mdx Resolved

cmunley1 reviewed Apr 16, 2026

View reviewed changes

Comment thread docs/contribute/development-setup.md Resolved

lbliii and others added 2 commits June 16, 2026 13:16

Merge remote-tracking branch 'origin/main' into llane/contributing-ud…

9893baf

…pates Signed-off-by: Lawrence Lane <llane@nvidia.com>

lbliii requested a review from a team as a code owner June 16, 2026 17:23

Merge branch 'main' into llane/contributing-udpates

5e3a7eb

lbliii requested review from cmunley1, jmabry and lbliii June 16, 2026 17:25

lbliii added 2 commits June 16, 2026 13:36

Merge branch 'main' into llane/contributing-udpates

1e521c0

Merge branch 'main' into llane/contributing-udpates

40888c9

jmabry previously approved these changes Jun 26, 2026

View reviewed changes

sephmard added the documentation Improvements to documentation label Jun 29, 2026

sephmard added this to NeMo Gym 0.4.0 - July 1 Jun 29, 2026

github-project-automation Bot moved this to Dev Todo in NeMo Gym 0.4.0 - July 1 Jun 29, 2026

github-actions Bot added the sla:review-overdue Review response is over the one-business-day SLA label Jul 17, 2026

github-actions Bot mentioned this pull request Jul 17, 2026

[Tracker] Pull request handoff SLA #2067

Open

jmabry reviewed Aug 11, 2026

View reviewed changes

Comment thread fern/versions/latest/pages/contribute/development-setup.mdx Resolved

jmabry reviewed Aug 11, 2026

View reviewed changes

Comment thread fern/versions/latest/pages/contribute/development-setup.mdx Resolved

jmabry previously approved these changes Aug 11, 2026

View reviewed changes

sephmard and others added 2 commits August 11, 2026 13:34

Merge branch 'main' into llane/contributing-udpates

9671a47

Update fern/versions/latest/pages/contribute/development-setup.mdx

18824e3

Co-authored-by: JOSHUA MABRY <mabryjn@gmail.com> Signed-off-by: Seph Mard <seph.mard@gmail.com>

sephmard dismissed jmabry’s stale review via 18824e3 August 11, 2026 17:34

sephmard and others added 3 commits August 11, 2026 13:38

Merge remote llane/contributing-udpates into pickup branch

c06177b

Signed-off-by: Seph Mard <smard@nvidia.com>

Merge branch 'main' into llane/contributing-udpates

ab650d8

sephmard disabled auto-merge August 11, 2026 17:39

sephmard added 2 commits August 11, 2026 13:44

Merge remote llane/contributing-udpates

40b0ad8

jmabry requested changes Aug 11, 2026

View reviewed changes

docs: make AGENTS.md the unified agent instructions source

10698cf

Merge former CLAUDE.md content into AGENTS.md (DCO -s only; -S optional) and turn CLAUDE.md into a symlink so Claude Code and other tools stay in sync. Signed-off-by: Seph Mard <smard@nvidia.com>

This comment was marked as spam.

Sign in to view

sephmard requested review from cmunley1 and jmabry August 11, 2026 18:17

jmabry approved these changes Aug 11, 2026

View reviewed changes

cmunley1 reviewed Aug 11, 2026

View reviewed changes

cmunley1 approved these changes Aug 11, 2026

View reviewed changes

Merge branch 'main' into llane/contributing-udpates

df07975

sephmard removed the request for review from lbliii August 11, 2026 18:52

kajalj22 approved these changes Aug 11, 2026

View reviewed changes

sephmard merged commit ab2d9c4 into main Aug 11, 2026
17 checks passed

sephmard deleted the llane/contributing-udpates branch August 11, 2026 18:56

github-project-automation Bot moved this from Dev Todo to Done in NeMo Gym 0.6.0 - Sept 2 Aug 11, 2026

Conversation

vadam5 commented Mar 11, 2026

Uh oh!

Uh oh!

jmabry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cmunley1 commented Apr 16, 2026

Uh oh!

Uh oh!

copy-pr-bot Bot commented Jun 16, 2026

Uh oh!

lbliii commented Jun 16, 2026

Uh oh!

github-actions Bot commented Jun 16, 2026

Uh oh!

Uh oh!

Uh oh!

jmabry left a comment

Choose a reason for hiding this comment

Uh oh!

sephmard commented Aug 11, 2026

Uh oh!

claude Bot commented Aug 11, 2026

Uh oh!

jmabry left a comment

Choose a reason for hiding this comment

Uh oh!

sephmard commented Aug 11, 2026

Uh oh!

This comment was marked as spam.

Uh oh!

jmabry left a comment

Choose a reason for hiding this comment

Uh oh!

cmunley1 Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

cmunley1 Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants