Repository navigation
cp: ci: bump cherry-pick workflow to v1.12.2, alert Gym channel (4119) into r0.7.0 - #4124
Merged
Merged
Conversation
## Summary - Bump the shared cherry-pick workflow pin in `.github/workflows/cherry-pick-release-commit.yml` from `v0.63.0` to `v1.12.2`. - Send the workflow's conflict alert to the Gym alerts channel by passing the team channel webhook - Tag the Gym support group on the alert with `notify-mention`. ## Why `v0.63.0` ignores command failures. When a release-labeled PR conflicts with the release branch, the job: - still force-pushes a `cherry-pick-<number>-<release branch>` branch that contains only the release branch (no change), - reports the failure only to a Slack webhook that no longer works, and `curl` treats the Slack error response (`no_service`) as success, - finishes green, so nobody learns the cherry-pick never happened and no `cp:` PR exists. `v1.12.2` fixes this: the job fails on a conflict, no empty branch is pushed, and a failed Slack post is logged as an error instead of hiding the result. Pointing `SLACK_WEBHOOK` at the team channel webhook makes the alert actually arrive, with the PR author, a PR link and the support group tag. ## Test plan Tested on a throwaway trigger branch with a dummy release branch (the workflow file from this PR, with the trigger branch, target-branch pattern and CI label overridden and the mention pointed at one user instead of the group). All throwaway branches and the test label were deleted afterwards. - [x] Pinned SHA `b7c7f7d585ad8f529a111e69afcbf14f0279663e` matches the `v1.12.2` tag in `NVIDIA-NeMo/FW-CI-templates` - [x] Org-level `PAT` and repo-level `SLACK_TEAM_CHANNEL_WEBHOOK` secrets confirmed present - [x] Push with no release label: job succeeds, nothing cherry-picked - [x] Conflicting release-labeled PR: job fails on the conflict, no empty `cherry-pick-*` branch is pushed, and the failure alert is posted to the Gym alerts channel with the mention rendered --------- Signed-off-by: Kajal Jain <kajalj@nvidia.com> Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Contributor
Author
|
/ok to test dd820e3 |
kajalj22
approved these changes
Oct 6, 2026
kajalj22
enabled auto-merge (squash)
October 6, 2026 19:03
kajalj22
disabled auto-merge
October 6, 2026 19:19
Contributor
|
/ok to test e87d25c |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beep boop [🤖]: Hi @kajalj22 👋,