Skip to content

fix(spider2): AUT-2464 avoid database downloads during test startup - #3874

Merged
ko3n1g merged 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:fix/spider2-test-no-download
Oct 1, 2026
Merged

ko3n1g merged 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:fix/spider2-test-no-download

Conversation

@svcnemo-autobot

Copy link
Copy Markdown
Contributor

Background

Nightly run 36859047483 failed during Spider2-Lite pytest configuration when Google Drive returned an invalid ZIP. This focused CI fix follows a maintainer request; no separate issue is needed.

What changed

Remove the unconditional ensure_spider2_lite() call and unused import from the test conftest.

Details

Preserve pytest marker registration. Existing unit tests use a tiny SQLite fixture and mock database provisioning. Production database setup is unchanged; no API, configuration, or benchmark-result changes.

Tested

  • git diff --check passed; signed commit verified.
  • Managed lint, core unit tests, and server shard 2/8 attempted but blocked during dependency setup: the checkout mount hides the image’s baked uv and pre-commit caches. No test/lint pass claimed.
  • GitHub CI pending.
  • Model rollout: N/A, test-startup-only change.

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added area:environment Individual environments, benchmarks, verifiers, and environment-specific resources servers complexity:low Localized change in one scope with a small, straightforward review surface labels Oct 1, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test 09dedd5

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

πŸ”„ Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/36874124725

Merged via the queue into NVIDIA-NeMo:main with commit 7a19900 Oct 1, 2026
39 checks passed

This branch was previously deployed

1 inactive deployment
public β€” 09dedd53 Deployed Oct 1, 2026 by copy-pr-bot[bot] via release / finalize / notify #4105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:environment Individual environments, benchmarks, verifiers, and environment-specific resources servers complexity:low Localized change in one scope with a small, straightforward review surface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants