Repository navigation
Stop sandboxes when post-start setup raises - #3425
Merged
bxyu-nvidia merged 2 commits intoSep 16, 2026
Merged
bxyu-nvidia merged 2 commits into
bxyu-nvidia merged 2 commits into
Conversation
Signed-off-by: Kelly <ekellbuchanan@gmail.com>
ekellbuch
marked this pull request as ready for review
September 16, 2026 05:59
Signed-off-by: Kelly <ekellbuchanan@gmail.com>
bxyu-nvidia
approved these changes
Sep 16, 2026
Contributor
|
/ok to test f3c4af8 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Terminal-Bench 2.1, SWE-bench, and DeepSWE run setup commands after starting a task container. If setup raises an exception, the caller never receives the container handle. The task fails, but the container can remain running until expiry or manual cleanup.
AsyncSandbox.start_with_setup()starts the container, runs setup, and attempts to stop the container if setup raises. The three resources servers now use this shared helper. Successful setup and subsequent agent execution and verification are unchanged.The helper handles exceptions, including cancellation. A nonzero command exit alone does not trigger cleanup. If stopping the container also raises, the cleanup exception propagates with the setup exception retained as Python exception context.
Checklist
pre-commit run --all-files) (so CI lint/format/copyright pass).git commit -s) (so the DCO check passes).