Repository navigation
Add Ray Serve gateway for multi-instance vLLM spanning multiple nodes per instance - #3214
Merged
Merged
Conversation
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
prokotg
reviewed
Sep 10, 2026
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
oyilmaz-nvidia
marked this pull request as ready for review
September 13, 2026 16:41
…i-node-no-rr # Conflicts: # nemo_gym/orchestration/api.py # nemo_gym/orchestration/executors/script_templates.py # tests/unit_tests/test_slurm_script.py
Contributor
Author
|
/ok to test 11e412d |
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
oyilmaz-nvidia
enabled auto-merge (squash)
September 14, 2026 15:46
Contributor
Author
|
/ok to test 3db55fc |
ananthsub
pushed a commit
to ananthsub/Gym
that referenced
this pull request
Sep 29, 2026
…Mo#3749) ## Background Addresses the flaky port-uniqueness test introduced in NVIDIA-NeMo#3214 and reported by [nightly CI](https://github.com/NVIDIA-NeMo/Gym/actions/runs/36477218352). A separate issue is unnecessary for this focused test correction. ## What changed Replace the uniqueness and subsequent-rebind assertions with parameterized, deterministic socket-contract coverage. ## Details Assert IPv4/TCP socket creation, binding to port 0, returning the assigned port, and context-manager cleanup. Once the temporary socket closes, neither uniqueness nor later availability is guaranteed. Production behavior and compatibility are unchanged. Documentation and model rollouts: N/A, test-only change. ## Tested - `git diff --check` passed. - `scripts/ci/core_unit_tests.sh`: blocked before tests by missing offline setuptools build dependencies. - `scripts/ci/lint.sh`: blocked during pre-commit environment installation by unreachable PyPI. - GitHub CI validation is pending, as requested. Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nemo_gym/orchestration/ray_serve_gateway.py) that manages both instance creation and request routing for multi-instance vLLM deployments ingym eval submit, replacing vLLM's own--data-parallel-size/multi-node DP mechanism for topologies it can't express.number_of_instances > 1— each instance now gets its ownvllm serve --distributed-executor-backend rayprocess, explicitly pinned to a distinct slice of nodes via Ray actor node-affinity, so instances can themselves span nodes (e.g. TP8×PP2 across 2 nodes/instance, 2 instances, 4 nodes total).use_ray_serve: truefield onVllmServiceConfigfor topologies that would otherwise work fine with vLLM's own DP.driver.gym_install's repo/ref directly into the vLLM service's own container (git clone+ run as a standalone script — nonemo_gympackage install there, to avoid clobbering vLLM's pinnedtorch/ray), auto-installinggitif the image doesn't bundle it.