Repository navigation
score reasoning only but completed responses as zero for lmarena_v3 - #3097
Merged
Merged
Conversation
Signed-off-by: Julien Veron Vialard <jveronvialar@nvidia.com>
…arena-reasoning-only-scoring
bxyu-nvidia
approved these changes
Sep 6, 2026
Contributor
|
/ok to test dfddf5f |
jkyi-nvidia
pushed a commit
that referenced
this pull request
Sep 11, 2026
…3097) ## What does this PR do? score rollouts with policy responses marked as completed but containing only reasoning content as zero, instead of treating them as failures and excluding them from lmarena_v3 score calculation ## Checklist - [X] I have read the [contributing guidelines](https://docs.nvidia.com/nemo/gym/latest/contribute/development-setup). - [X] The change is focused; unrelated "drive-by" edits are tracked as separate issues/PRs. - [X] Tests added or updated and pass locally, or N/A for docs-only / non-code changes (so CI unit/server checks pass when applicable). - [X] Pre-commit checks pass locally (`pre-commit run --all-files`) (so CI lint/format/copyright pass). - [X] All commits have DCO sign-off (`git commit -s`) (so the DCO check passes). Signed-off-by: Julien Veron Vialard <jveronvialar@nvidia.com> Signed-off-by: Junkeun Yi <jkyi@nvidia.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
score rollouts with policy responses marked as completed but containing only reasoning content as zero, instead of treating them as failures and excluding them from lmarena_v3 score calculation
Checklist
pre-commit run --all-files) (so CI lint/format/copyright pass).git commit -s) (so the DCO check passes).