Repository navigation
Conversation
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Contributor
|
/ok to test 1a88045 |
kajalj22
approved these changes
Aug 30, 2026
kajalj22
enabled auto-merge (squash)
August 30, 2026 01:48
jkyi-nvidia
pushed a commit
that referenced
this pull request
Sep 11, 2026
## Background Nightly run 33223378543 failed when the live Fireworks smoke test produced only an `agent_run_error` rollout. ## What changed - Temporarily disable the Fireworks provider E2E job with an explicit workflow comment. - Allow its expected skipped result in the nightly summary while continuing to reject failures. - Cover the temporary condition and summary behavior in CI tests. ## Details ```mermaid flowchart LR A[Nightly CI] --> B[Fireworks E2E skipped] B --> C[Summary accepts skip] C --> D[Other nightly gates remain enforced] ``` ## Tested - `tests/unit_tests/test_ci_environment.py`: 69 passed. - Workflow YAML parsed and temporary skip semantics verified. - Full pre-commit/core gates were attempted but blocked by the typed checkout lacking local Git metadata and a Git executable; GitHub CI remains authoritative. Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com> Signed-off-by: Junkeun Yi <jkyi@nvidia.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Nightly run 33223378543 failed when the live Fireworks smoke test produced only an
agent_run_errorrollout.What changed
Details
Tested
tests/unit_tests/test_ci_environment.py: 69 passed.