Repository navigation
fix(opensandbox): surface OOM status after exec 502 - #2604
Merged
Merged
Conversation
OpenSandbox already reports lifecycle details after a container OOMs, but Gym returned only the proxy 502. Surface an actionable OOM error after a bounded status reconciliation window while preserving non-OOM failures. Add focused unit coverage and a low-resource end-to-end reproducer. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Hemil Desai <hemild@nvidia.com>
The deployment-specific E2E script is useful for local validation but does not belong in the shipped Gym repository. Signed-off-by: Hemil Desai <hemild@nvidia.com>
Keep the OOM diagnosis and lifecycle status without prescribing a memory configuration change to callers. Signed-off-by: Hemil Desai <hemild@nvidia.com>
hemildesai
marked this pull request as ready for review
August 18, 2026 23:01
Contributor
Author
|
/claude review |
Contributor
Author
|
/ok to test 9e20c69 |
hemildesai
marked this pull request as draft
August 18, 2026 23:03
hemildesai
marked this pull request as ready for review
August 18, 2026 23:03
Raise the enriched OOM error as soon as reconciliation finds it instead of storing and re-reading the same lifecycle fields. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Hemil Desai <hemild@nvidia.com>
Contributor
Author
|
/claude review |
Contributor
Author
|
/ok to test 42f732d |
hemildesai
marked this pull request as draft
August 18, 2026 23:08
hemildesai
marked this pull request as ready for review
August 18, 2026 23:09
Contributor
|
SHIP β LGTM, no reliability concerns. Focused, defensive change to OpenSandbox exec error classification. On a submission/polling 502 (or an existing Verified:
Worst case is a bounded ~5s extra latency on a 502 when the status stays non-terminal β acceptable for the improved diagnosability. |
bxyu-nvidia
approved these changes
Aug 19, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Example OOM message
Test plan
pytest -q tests/unit_tests/test_opensandbox_provider.py(45 passed)Failed/OOMKilled, Gym surfaced the OOM diagnosis, and cleanup succeededπ€ Generated with Claude Code