Repository navigation
fix(cli): accept -v/--verbose before the subcommand; stop suggesting a flag as its own correction - #2303
Merged
Conversation
Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com>
kajalj22
added
the
r0.5.0
adil-a
approved these changes
Aug 4, 2026
kajalj22
added a commit
that referenced
this pull request
Aug 5, 2026
…ting a flag as its own correction (2303)` into `r0.5.0` (#2335) beep boop [🤖]: Hi @e-dobrowolska 👋, we've cherry picked #2303 into for you! 🚀 Please review and approve this cherry pick by your convenience! Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com> Co-authored-by: Ewa Dobrowolska <117774842+e-dobrowolska@users.noreply.github.com> Co-authored-by: Anwith Kiran <anwithk@nvidia.com> Co-authored-by: kajalj22 <kajalj@nvidia.com>
OlegSudakov
pushed a commit
to OlegSudakov/Gym
that referenced
this pull request
Aug 7, 2026
…a flag as its own correction (NVIDIA-NeMo#2303) Related to NVIDIA-NeMo#1434 Fixes DEFECT A — `-v` / `--verbose` is not global. Issue: `-v`/`--verbose` was registered only on leaf subparsers, so `gym -v list benchmarks` failed while the trailing form worked - it is now on the top-level parser too. The "did you mean?" hint also matched a misplaced flag against itself; the rejected token is now excluded from its own candidate set. Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com> Co-authored-by: Anwith Kiran <anwithk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1434
Fixes DEFECT A —
-v/--verboseis not global.Issue:
-v/--verbosewas registered only on leaf subparsers, sogym -v list benchmarksfailed while the trailing form worked - it is now on the top-level parser too. The "did you mean?" hint also matched a misplaced flag against itself; the rejected token is now excluded from its own candidate set.