Repository navigation
ci: shard full server suite - #1842
Merged
Merged
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Contributor
|
/claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
||
| - name: Setup for test | ||
| run: | | ||
| export UV_CACHE_DIR="$HOME/.cache/uv" |
Contributor
There was a problem hiding this comment.
NOTE — full-test-suite sets UV_CACHE_DIR but has no actions/cache@v4 step, so the cache is written but never persisted across runs. The new server-suite job does cache correctly. Inconsistency, not a bug — but adding the same cache block here would speed up core-test runs too.
|
|
||
| server-suite-result: | ||
| name: Server suite | ||
| runs-on: ubuntu-latest |
Contributor
There was a problem hiding this comment.
NOTE — ng_test_all moved out of the full-test-suite job into server-suite-result. If branch protection requires the full-test-suite check to pass, server test failures are now invisible to the merge gate until server-suite-result is added as a required status check. Worth confirming the repo's branch protection rules are updated to match.
kajalj22
approved these changes
Jun 30, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Test run
https://github.com/NVIDIA-NeMo/Gym/actions/runs/28474026537
https://github.com/NVIDIA-NeMo/Gym/actions/runs/28474433450
Notes