Skip to content

fix(hermes_agent): configurable api key and chat template args - #1794

Merged
cmunley1 merged 4 commits into
mainfrom
cmunley1/fix-hermes-endpoint
Aug 17, 2026
Merged

cmunley1 merged 4 commits into
mainfrom
cmunley1/fix-hermes-endpoint

Conversation

@cmunley1

Copy link
Copy Markdown
Contributor

No description provided.

cmunley1 added 2 commits June 26, 2026 23:09
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jun 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cmunley1
cmunley1 enabled auto-merge (squash) June 30, 2026 04:18
@cmunley1
cmunley1 disabled auto-merge June 30, 2026 04:18
@anwithk
anwithk requested a review from Glorf July 15, 2026 17:10
@github-actions github-actions Bot added the sla:review-overdue Review response is over the one-business-day SLA label Jul 17, 2026
@cmunley1

Copy link
Copy Markdown
Contributor Author

/claude review

@claude

claude Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

SHIP β€” no reliability concerns.

Two additive, backward-compatible config knobs on the Pydantic HermesAgentConfig. Defaults preserve existing behavior (chat_template_kwargs_enabled=True keeps the thinking-kwargs injection; api_key defaults to the prior "gym" sentinel when unset and env is empty). os is already imported; no async paths, verifier/scorer logic, or public API surface touched. The sibling Pydantic fields already carry Python-side defaults not mirrored in the exemplar YAML, so this follows the established pattern.

NOTE β€” api_key env fallback (app.py:293). self.config.api_key or os.environ.get("OPENAI_API_KEY", "gym") means a globally-set OPENAI_API_KEY (common in dev shells) is now forwarded as the credential to whatever base_url the model server resolves to. Harmless when that's the local Gym model server (key ignored), but it silently sends a real credential to an internal endpoint where the code previously always sent the inert "gym". Author's call β€” if the intent is only to override for external providers, gating on an explicit config value rather than the ambient env var would be tighter. Not a blocker.

@cmunley1
cmunley1 merged commit 6a9f75e into main Aug 17, 2026
9 checks passed
@cmunley1
cmunley1 deleted the cmunley1/fix-hermes-endpoint branch August 17, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sla:review-overdue Review response is over the one-business-day SLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant