Repository navigation
fix: return in-scope-filtered agent configs from load_and_validate_server_instance_configs - #1410
Merged
ananthsub merged 1 commit intoMay 29, 2026
Conversation
cmunley1
approved these changes
May 28, 2026
ananthsub
force-pushed
the
fix/train-data-in-scope-return
branch
from
May 28, 2026 22:50
2d8c4b8 to
a1a7edc
Compare
ananthsub
enabled auto-merge (squash)
May 28, 2026 22:50
…ad_and_validate_server_instance_configs load_and_validate_server_instance_configs() builds an agent_configs_with_in_scope_datasets list that drops agents whose datasets are entirely out of scope for the current mode and restricts mixed agents to their in-scope datasets, but the function then returned the unfiltered agent_configs_with_data. Downstream consumers (load_datasets, validate_samples_and_aggregate_metrics, collate_samples) therefore saw every agent that had any dataset and, for agents whose datasets were all out of scope, never had their data filtered at all. Return agent_configs_with_in_scope_datasets and fix the misleading count in the accompanying printout. Add a regression test that constructs three in-memory agent configs (in-scope-only, out-of-scope-only, mixed) in example_validation mode and asserts the out-of-scope-only agent is dropped while the mixed agent is restricted to its in-scope datasets. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
force-pushed
the
fix/train-data-in-scope-return
branch
from
May 29, 2026 15:52
a1a7edc to
be2d67e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_and_validate_server_instance_configs()builds anagent_configs_with_in_scope_datasetslist that drops agents whose datasets are entirely out of scope for the current mode and restricts mixed agents to their in-scope datasets, but the function then returned the unfilteredagent_configs_with_data.Downstream consumers (load_datasets, validate_samples_and_aggregate_metrics, collate_samples) therefore saw every agent that had any dataset and, for agents whose datasets were all out of scope, never had their data filtered at all.
Fix: return
agent_configs_with_in_scope_datasetsand fix the misleading count in the accompanying printout