Repository navigation
Use File instead of IO for file operations - #105367
Merged
Merged
Conversation
7 tasks done
Contributor
Author
|
CC @samford because I'm not sure about some of these |
vitorgalvao
previously approved these changes
May 8, 2021
samford
requested changes
May 9, 2021
Bo98
previously approved these changes
May 10, 2021
Member
|
Thanks! |
SMillerDev
approved these changes
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
After making all changes to a cask, verify:
brew audit --cask {{cask_file}}is error-free.brew style --fix {{cask_file}}reports no offenses.See Homebrew/brew#11140
Replace
IO.writeandIO.readwithFile.writeandFile.read, respectively, inj,minecraft-server, andopenzfs.Note that I was unable to test this for
openzfsbecause it depends on certain macOS versions that I don't have access to (i.e. doesn't work on Big Sur).