Skip to content

ssh-tpm-keygen: set default number of bits for ecdsa and rsa - #44

Merged
Foxboron merged 1 commit into
Foxboron:masterfrom
stigtsp:keygen-set-default-num-bits
Mar 6, 2024
Merged

Foxboron merged 1 commit into
Foxboron:masterfrom
stigtsp:keygen-set-default-num-bits

Conversation

@stigtsp

@stigtsp stigtsp commented Mar 3, 2024

Copy link
Copy Markdown
Contributor

When calling ssh-tpm-agent without -b the number of bits defaults to 0, leading to:

  invalid ecdsa key length: TPM does not support 0 bits

This sets the default number of bits to 256 for ecdsa and or 2048 for rsa.

Closes #42

@stigtsp
stigtsp force-pushed the keygen-set-default-num-bits branch from 3d9e2ab to 1b96a2d Compare March 3, 2024 02:06
When calling ssh-tpm-agent without `-b` the number of bits defaults to
0, leading to:

  invalid ecdsa key length: TPM does not support 0 bits

This sets the default number of bits to 256 for ecdsa and or 2048 for
rsa.
@stigtsp
stigtsp force-pushed the keygen-set-default-num-bits branch from 1b96a2d to 0757edd Compare March 3, 2024 02:09
@Foxboron
Foxboron merged commit 47b9848 into Foxboron:master Mar 6, 2024
@Foxboron

Foxboron commented Mar 6, 2024

Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.3.0: default key length not valid

2 participants