[novag]

• Allow specifying an owner password when creating the SRK

[novag]

Thanks for the very quick review! Unfortunately, I've only now found the time to address the review.

[Foxboron]

Still missing a test to check that ownerpassword actually works for the key loading. But I can write that up if you dont want to figure out how.

[novag]

Thanks! I will push the test soon. However, this PR is blocked until google/go-tpm#357 is merged.

[Foxboron]

Currently away so won't review this until later this weeks, but why do you need HierarchyChangeAuth for this change?

[novag]

It's required to set an initial owner password for the test. Or is there another way that I am not aware of to initialize the TPM simulator with an owner password?

[Foxboron]

Ah, this makes sense :)

I haven't read the complete TPM spec and stuff I do is very much me learning as a I go. I haven't messed around with owner password so you are probably correct.

[novag]

I haven't read the whole spec either, but I'm pretty sure there's no other command for it. Thanks for your quick reply! :)

[Foxboron]

Please do tell me if the go-tpm patches takes too much time for you. I'd rather have this merged without a test then having it go stale because you are not able to work on the go-tpm patch :)

[Foxboron]

LGTM.

Thanks for working on this :)