Skip to content

Namespace migration and WinUI3 package MicrosoftToolkit.WinUI.Lottie - #500

Merged
aborziak-ms merged 7 commits into
mainfrom
winui3-package2
May 25, 2022
Merged

aborziak-ms merged 7 commits into
mainfrom
winui3-package2

Conversation

@aborziak-ms

@aborziak-ms aborziak-ms commented May 24, 2022 •

Copy link
Copy Markdown
Collaborator

Added project for WinUI3 package. Since there are a lot of namespaces changes also added preprocessor flag to distinguish WinUI 3 package from UWP package.

@aborziak-ms
aborziak-ms requested a review from a team May 24, 2022 19:49
Comment thread source/Lottie/LottieVisualOptions.cs Resolved

@raymond-wh-leung raymond-wh-leung left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michael-hawker michael-hawker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments and info about where we're heading with the WCT.

Also not sure if you've done an audit for Dispatcher usage and XamlRoot for the general migration guidance. If things work in XAML Islands today, you should be fine. But always good to check if you missed a move to DispatcherQueue.

Comment thread source/Lottie/ImageAssetHandler.cs Resolved
Comment thread source/Lottie/ImageAssetHandler.cs Resolved
@aborziak-ms aborziak-ms changed the title Added WinUI3 package MicrosoftToolkit.WinUI.Lottie Namespace migration and WinUI3 package MicrosoftToolkit.WinUI.Lottie May 25, 2022
Comment thread Directory.Build.props Resolved
Comment thread README.md Resolved

@michael-hawker michael-hawker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things I think to sort out how the packages will be created.

Comment thread Lottie-Windows/Lottie-Windows.csproj Resolved
Comment thread README.md
| Target | Branch | Status | Recommended NuGet package |
| ------ | ------ | ------ | ------ |
| 7.1.0 release | main | [![Build Status](https://dev.azure.com/dotnet/WindowsCommunityToolkit/_apis/build/status/CommunityToolkit.WinUI.Lottie?branchName=main)](https://dev.azure.com/dotnet/WindowsCommunityToolkit/_build/latest?definitionId=61&branchName=main) | [![NuGet](https://img.shields.io/nuget/v/CommunityToolkit.WinUI.Lottie.svg)](https://www.nuget.org/packages/CommunityToolkit.WinUI.Lottie/) |
| 7.1.0 release | main | [![Build Status](https://dev.azure.com/dotnet/WindowsCommunityToolkit/_apis/build/status/Microsoft.Toolkit.Uwp.UI.Lottie?branchName=main)](https://dev.azure.com/dotnet/WindowsCommunityToolkit/_build/latest?definitionId=61&branchName=main) | [![NuGet](https://img.shields.io/nuget/v/Microsoft.Toolkit.Uwp.UI.Lottie.svg)](https://www.nuget.org/packages/Microsoft.Toolkit.Uwp.UI.Lottie/) |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can clean this up later, as we'll probably want to split out and have NuGet shields for both the UWP and the WinUI packages. For now we can leave as-is and not worry about it until things are published and we have all the actual live links.

@michael-hawker michael-hawker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, think things are set now. Just need to try from the DevOps feed and make sure the packages work alright from UWP/WinUI 3 apps!

@aborziak-ms
aborziak-ms merged commit 9cec912 into main May 25, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the winui3-package2 branch May 25, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants