Repository navigation
Fixed visibility property for visuals with shadow - #492
Merged
Merged
Conversation
| } | ||
|
|
||
| // Here we are moving default value of "IsVisible" to target | ||
| target.IsVisible = source.IsVisible; |
There was a problem hiding this comment.
If the Animate.WithKeyFrame() or WithExpression() calls StartAnimation() that targets IsVisibile, this set here (if the the value gets changed), will stop the animation above, maybe this needs to be set first before the Animate.WithKeyFrame() calls above? #Closed
Collaborator
Author
There was a problem hiding this comment.
This class is just a "mock class" of a real WinComp class (Lottie-Windows\source\WinCompData\Visual.cs) so it just stores the data in it, after all the translation is done this class is used to instantiate real WinComp instances. So it should be fine, but I reordered it anyway
| // We need to transfer "IsVisible" property from source to result | ||
| // because result is now the root visual for both shadow and source. | ||
| // Otherwise "IsVisible" property will be applied only to source. | ||
| MoveIsVisibleProperty(context, source, result); |
Collaborator
Author
There was a problem hiding this comment.
Transfer sounds good, done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing translation of shadow effect. If source of the shadow is not visible it does not make shadow disappear, so here I'm pushing
IsVisibleproperty up so that this property controls visibility of both, source and shadow visuals.