Skip to content

Fixes for MSBuild task - #444

Merged
eliezerpMS merged 1 commit into
CommunityToolkit:masterfrom
aschultz:users/aschultz/msbuild
Apr 27, 2021
Merged

Fixes for MSBuild task#444
eliezerpMS merged 1 commit into
CommunityToolkit:masterfrom
aschultz:users/aschultz/msbuild

Conversation

@aschultz

@aschultz aschultz commented Apr 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Parameter validation no longer fails on valid params
  • Fixed props file path to LottieGen dll (LottieGen.MSBuild props file has invalid path to DLL #443)
  • Fixed path generation for LottieGen exe
  • Converted parameter types which are not supported by MSBuild to acceptable types
  • Added escaping to command-line args to avoid mangling file paths

@aschultz
Fixes for MSBuild task:
2f7905c 
- Parameter validation no longer fails on valid params
- Fixed props fle path to LottieGen dll
- Fixed path generation for LottieGen exe
- Converted parameter types which are not supported by MSBuild to acceptable types
- Added escaping to command-line args to avoid mangling file paths
@aschultz
aschultz requested a review from a team as a code owner April 23, 2021 02:33
eliezerpMS
eliezerpMS approved these changes Apr 27, 2021
View reviewed changes

@eliezerpMS eliezerpMS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eliezerpMS
eliezerpMS merged commit bc0e8ae into CommunityToolkit:master Apr 27, 2021
@aschultz
aschultz deleted the users/aschultz/msbuild branch April 27, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eliezerpMS eliezerpMS eliezerpMS approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aschultz @eliezerpMS