Repository navigation
Support a Gaussian blur effect field that sometimes shows up. - #399
Merged
Merged
Conversation
And polish the yaml serializer a bit.
simeoncran
commented
Dec 2, 2020
| @@ -28,7 +29,7 @@ public static implicit operator YamlScalar(string value) | |||
| var escapedValue = value; | |||
| if (escapedValue is null) | |||
Contributor
Author
There was a problem hiding this comment.
value is not nullable. Why is escapedValue nullable? #Closed
derobinsMSFT
reviewed
Dec 2, 2020
| break; | ||
|
|
||
| case 3: | ||
| // Optional parameter. Parse it is an animatable because it has the |
There was a problem hiding this comment.
is [](start = 56, length = 2)
"as" #Closed
derobinsMSFT
reviewed
Dec 2, 2020
| case 3: | ||
| // Optional parameter. Parse it is an animatable because it has the | ||
| // animatable format, however it would be very strange if the value | ||
| // was actually animated so convert it to non-animated bool; |
There was a problem hiding this comment.
; [](start = 83, length = 1)
Nit: period. #Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And polish the yaml serializer a bit.