Repository navigation
Implement DropShadow effect. - #392
Merged
Merged
Conversation
This is currently turned off, however we do everything except adding the shadow to the LayerVisual so that the code is being exercised. I have not output any issues yet for the cases we don't handle because we don't know how long before LayerVisual is fixed, and the set of issues might need changing when LayerVisual is finally working.
simeoncran
commented
Nov 23, 2020
| CreateAnimatableParser((in LottieJsonElement element) => element.AsDouble() ?? 0); | ||
|
|
||
| static readonly AnimatableParser<Opacity> s_animatableOpacityParser = CreateAnimatableParser(ParseOpacity); | ||
| static readonly AnimatableParser<Opacity> s_animatableOpacityParserByte = CreateAnimatableParser(ParseOpacityByte); |
Contributor
Author
There was a problem hiding this comment.
Maybe this should called s_animatableOpacityByteParser #Closed
| @@ -308,9 +308,6 @@ static float Clamp(float value, float min, float max) | |||
|
|
|||
| static Sn.Vector2 ClampedVector2(float x, float y) => Vector2(Clamp(x, 0, 1), Clamp(y, 0, 1)); | |||
There was a problem hiding this comment.
static Sn.Vector2 [](start = 8, length = 17)
A couple other methods in this class also have equivalents in ConvertTo. #Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently turned off, however we do everything except adding the shadow to the LayerVisual so that the code is being exercised.
I have not output any issues yet for the cases we don't handle because we don't know how long before LayerVisual is fixed, and the set of issues might need changing when LayerVisual is finally working.