Repository navigation
Support .lottie files in LottieGen. - #376
Merged
Merged
Conversation
See https://dotlottie.io for file details. LottieGen will now read .lottie files as well as .json files.
simeoncran
marked this pull request as draft
October 25, 2020 18:53
simeoncran
marked this pull request as ready for review
October 26, 2020 17:11
simeoncran
commented
Oct 26, 2020
| using Microsoft.Toolkit.Uwp.UI.Lottie.DotLottie; | ||
|
|
||
| /// <summary> | ||
| /// Processes a file containing an animation and produces various generated outputs. |
Contributor
Author
There was a problem hiding this comment.
Can contain more than one animation. #Closed
| timestamp: _timestamp); | ||
|
|
||
| case ".json": | ||
| default: |
There was a problem hiding this comment.
It's not an error to have a file that doesn't end in .json or .lottie? #ByDesign
Contributor
Author
There was a problem hiding this comment.
Yeah, on purpose. Nothing requires JSON files to be .json. However .lottie files do need to be named with .lottie.
In reply to: 512253491 [](ancestors = 512253491)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://dotlottie.io for file details.
LottieGen will now read .lottie files as well as .json files.