Repository navigation
Code cleanup: take advantage of C# 8 features. - #370
Merged
Merged
Conversation
Also adds some more #nullable enable annotation so quieten code analysis. None of these changes should have changed any behaviors.
If all of these error suppressions are gone, is this file needed anymore? Or does Code Analysis always expect to find this file even if it's "empty"? #Closed Refers to: GlobalSuppressions.cs:1 in 1c4bdab. [](commit_id = 1c4bdab, deletion_comment = False) |
| @@ -192,14 +192,10 @@ bool TryInlineObject(YamlObject obj, int maximumWidth, [MaybeNullWhen(false)] ou | |||
| { | |||
| switch (obj.Kind) | |||
There was a problem hiding this comment.
switch (obj.Kind) [](start = 16, length = 17)
return (obj.Kind) switch? #Closed
Contributor
Author
There was a problem hiding this comment.
I tried, and failed. I think it's hitting a limitation of the nullable analysis. Even though the TryInline methods all return a string with MaybeNullWhen(false), the nullable analysis complains if this is a switch expression.
In reply to: 508131986 [](ancestors = 508131986)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds some more #nullable enable annotation so quieten code analysis.
None of these changes should have changed any behaviors.