Repository navigation
Add a WinUI3 mode to LottieGen. - #331
Merged
Merged
Conversation
This switch is intended to exist only until we fork LottieGen to be WinUI3 only. Until then it is a convenient way to have the code generator output code that needs little hand tweaking to work with WinUI3.
added 4 commits
August 5, 2020 14:48
WinUI3 implies the runtime is the latest version.
We don't need the CanvasGeometry class type anyway, but the motivation for this change is to make WinUI3 codegen work better while we don't have an officially supported Win2D.
| if (Info.WinUi3) | ||
| { | ||
| WriteInstantiateAndReturnAnimatedVisual(builder, Info.AnimatedVisualInfos.First()); | ||
| } |
| readonly string _interface; | ||
| readonly string _sourceInterface; | ||
| readonly string _winUiNamespace; | ||
| readonly string _winui3CastHack; |
There was a problem hiding this comment.
u [](start = 28, length = 1)
Nit: can this be capitalized (for consistency)? #Closed
… different machine. Getting errors in the pipeline build that seem to be a problem with a machine. I'm hoping this change will cause use to switch machines.
simeoncran
dismissed stale reviews from scott-moore-ms and derobinsMSFT
via
August 14, 2020 16:54
cf405c6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switch is intended to exist only until we fork LottieGen to be WinUI3 only. Until then it is a convenient way to have the code generator output code that needs little hand tweaking to work with WinUI3.