Skip to content

Backport Some ColorPicker Fluent2 Theme Fixes/Updates to Older Themes - #22578

Merged
MrJul merged 6 commits into
AvaloniaUI:mainfrom
robloo:robloo/legacy-colorpicker-theme-updates
Oct 29, 2026
Merged

MrJul merged 6 commits into
AvaloniaUI:mainfrom
robloo:robloo/legacy-colorpicker-theme-updates

Conversation

@robloo

@robloo robloo commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

What does the pull request do?

Update the legacy Simple and Fluent version 1 themes with fixes and changes from the Fluent version 2 theme. See #22569

What is the current behavior?

Themes are at the current baseline. Now out of sync with the Fluent2 updates and fixes.

What is the updated/expected behavior with this PR?

Both the Simple and Fluent version 1 themes have been updated where possible to match Fluent2 changes:

  • Update/simplify the ColorViewColorModelRadioButtonTheme. Just use BasedOn now.
  • Vertically center text input control content. This affects the Hex input TextBox as well as all component input NumericUpDowns.
  • Update color control base resources using theme dictionaries. When the themes were first written theme variants didn't yet exist. There were TODOs and placeholders that needed to finally be updated.
  • Fix Flyout content bottom CornerRadius. Just ensure the ColorPicker flyout background always picks up the correct corner radius from the Flyout itself. This doesn't visually change anything but now matches Fluent version 2.

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

None, the old resource keys are kept so there is no breaking change. Only Fluent2 updates the keys.

Obsoletions / Deprecations

None

Fixed issues

None

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

NuGet packages

The packages for this pull request have been published (workflow run):

@maxkatz6 maxkatz6 added bug area-theme Related to the simple or fluent theme. backport-candidate-12.1.x Consider this PR for backporting to 12.1 branch labels Oct 25, 2026
@MrJul
MrJul enabled auto-merge October 29, 2026 09:35
@MrJul
MrJul added this pull request to the merge queue Oct 29, 2026
Merged via the queue into AvaloniaUI:main with commit 1968b08 Oct 29, 2026
7 checks passed
@robloo
robloo deleted the robloo/legacy-colorpicker-theme-updates branch October 29, 2026 15:04
MrJul added a commit that referenced this pull request Nov 2, 2026
…#22578)

* Update/simplify the ColorViewColorModelRadioButtonTheme

* Vertically center text input control content

* Update color control base resources using theme dictionaries

* Fix Flyout content bottom CornerRadius

---------

Co-authored-by: Julien Lebosquain <julien@lebosquain.net>
@MrJul MrJul added backported-12.1.x and removed backport-candidate-12.1.x Consider this PR for backporting to 12.1 branch labels Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-theme Related to the simple or fluent theme. backported-12.1.x bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants