Repository navigation
Only allow setting AXFocused on keyboard-focusable elements on macOS - #22532
Merged
Merged
Conversation
NuGet packagesThe packages for this pull request have been published (workflow run):
|
MrJul
added
os-macos
area-accessibility
backport-candidate-12.1.x
MrJul
pushed a commit
that referenced
this pull request
Nov 2, 2026
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Gates
setAccessibilityFocused:inAvnAccessibilityElement'sisAccessibilitySelectorAllowed:on the peer'sIsKeyboardFocusable(), like the other setters there.What is the current behavior?
Every Avalonia automation element reports
AXFocusedas settable, including text blocks, layout containers and buttons withFocusable="False".What is the updated/expected behavior with this PR?
AXFocusedis settable only when the peer'sIsKeyboardFocusable()returns true. It stays readable on every element. Checked withAXUIElementIsAttributeSettableon aTextBox,Button,TextBlock, disabledButtonand non-focusableButtonin aStackPanel: only theTextBox, theButtonand the disabledButton(whose peer still reports it as keyboard-focusable) report true now.How was the solution implemented (if it's not obvious)?
There's no test for this: XCUITest doesn't expose whether an attribute is settable, so the Appium tests can't observe it. The existing Mac integration tests give the same results locally with and without the change.
Fixed issues
Fixes #22437