Repository navigation
Fix Popup.InheritsTransform using the X scale for the Y axis - #22457
Merged
MrJul merged 3 commits intoOct 19, 2026
Merged
Conversation
Contributor
Author
|
@cla-avalonia agree |
Collaborator
|
Contributor
Author
|
@cla-avalonia agree |
MrJul
added
bug
backport-candidate-12.1.x
MrJul
approved these changes
Oct 19, 2026
MrJul
enabled auto-merge
October 19, 2026 08:38
NuGet packagesThe packages for this pull request have been published (workflow run):
|
MrJul
added a commit
that referenced
this pull request
Nov 2, 2026
* Add failing test for Popup.InheritsTransform Y scale * Fix Popup.InheritsTransform using the X scale for the Y axis --------- Co-authored-by: Julien Lebosquain <julien@lebosquain.net>
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes the Y scale computed by
PopupwhenInheritsTransformis enabled.What is the current behavior?
UpdateHostSizingcomputesscaleYfrom the first row of the transform matrix (M11/M12), the same asscaleX. A popup underScaleTransform(1, 2)opens at 1×1, and underScaleTransform(2, 1)it opens at 2×2. This affectsComboBoxdrop-downs in both Fluent and Simple themes.What is the updated/expected behavior with this PR?
scaleYis computed from the second row (M21/M22), so each axis gets its own scale. Added a unit test that opens a popup over a placement target withScaleTransform(1, 2)and checks the host's transform and height.Checklist
Fixed issues
Fixes #22396