Repository navigation
Fix menu auto closing when reopened - #22399
Merged
Merged
Conversation
MrJul
added
bug
backport-candidate-12.1.x
NuGet packagesThe packages for this pull request have been published (workflow run):
|
grokys
approved these changes
Oct 23, 2026
MrJul
added a commit
that referenced
this pull request
Oct 28, 2026
* Add failing tests for reopened menu * Fix menu auto closing when reopened (cherry picked from commit 6a25cf4)
MrJul
added a commit
that referenced
this pull request
Nov 2, 2026
* Add failing tests for reopened menu * Fix menu auto closing when reopened
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes a menu automatically closing if it's reopened using the keyboard while its close timer is still active.
For example, using the mouse, quickly open a menu, then a submenu, then close everything.
Now, open the menu and submenu again, using the keyboard this time.
If all the steps above were done during the
MenuShowDelay(400ms), the submenu is incorrectly closed.The above was found using automation tests. It's unlikely that a user is fast enough to trigger this with the default delay.