Repository navigation
[Text] Fix RunIndex mapping in BidiReorderer - #22384
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gillibald
added
bug
area-textprocessing
backport-candidate-12.1.x
- BidiReordererTests: assert RunIndex is the visual position of each logical IndexedTextRun, and that textRuns ends up in visual order, for level sequences that form non-involutive permutations (the old lookup only worked for swaps and reversals). - TextLayoutTests: splitting runs with style spans must not change line width, per-character bounds or hit-test results, across LTR and RTL paragraphs with mixed Hebrew/Latin/digit text.
Gillibald
approved these changes
Oct 5, 2026
Gillibald
left a comment
Gillibald
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I have added some more test scenarios to make sure we do not break this in the future. It looks like this was a bug for many years.
Gillibald
enabled auto-merge
October 5, 2026 07:19
NuGet packagesThe packages for this pull request have been published (workflow run):
|
grokys
pushed a commit
to Evan260/Avalonia
that referenced
this pull request
Oct 7, 2026
* [Text] Fix RunIndex mapping in BidiReorderer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * [Text] Cover BidiReorderer run index mapping at both layers - BidiReordererTests: assert RunIndex is the visual position of each logical IndexedTextRun, and that textRuns ends up in visual order, for level sequences that form non-involutive permutations (the old lookup only worked for swaps and reversals). - TextLayoutTests: splitting runs with style spans must not change line width, per-character bounds or hit-test results, across LTR and RTL paragraphs with mixed Hebrew/Latin/digit text. --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Benedikt Stebner <Gillibald@users.noreply.github.com>
MrJul
pushed a commit
that referenced
this pull request
Oct 9, 2026
* [Text] Fix RunIndex mapping in BidiReorderer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * [Text] Cover BidiReorderer run index mapping at both layers - BidiReordererTests: assert RunIndex is the visual position of each logical IndexedTextRun, and that textRuns ends up in visual order, for level sequences that form non-involutive permutations (the old lookup only worked for swaps and reversals). - TextLayoutTests: splitting runs with style spans must not change line width, per-character bounds or hit-test results, across LTR and RTL paragraphs with mixed Hebrew/Latin/digit text. --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Benedikt Stebner <Gillibald@users.noreply.github.com>
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BidiReorderassignedRunIndexto the wrongIndexedTextRun(visual position used as the logical index). This shows with two or more LTR runs inside an RTL line: wrong text bounds, andGetTextBoundsthrows "Covered length must be greater than zero".🤖 Generated with Claude Code