Repository navigation
Apply IsSelected from items declared in XAML - #22363
Merged
Merged
Conversation
NuGet packagesThe packages for this pull request have been published (workflow run):
|
MrJul
added
bug
backport-candidate-12.1.x
emmauss
approved these changes
Oct 5, 2026
grokys
pushed a commit
to Evan260/Avalonia
that referenced
this pull request
Oct 7, 2026
* Add tests for a ComboBoxItem marked as selected in XAML * Apply IsSelected from inline items before their containers are realized
MrJul
pushed a commit
that referenced
this pull request
Oct 9, 2026
* Add tests for a ComboBoxItem marked as selected in XAML * Apply IsSelected from inline items before their containers are realized
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Applies
IsSelectedset on an item declared in XAML as soon as the control is initialized.What is the current behavior?
A
ComboBoxItemwritten withIsSelected="True"isn't selected when the window opens. The flag is only read when the item's container is realized, and aComboBoxdoesn't realize its items until the drop-down is opened, so the box stays blank andSelectedIndexstays at -1 until the user opens it once.What is the updated/expected behavior with this PR?
Inline items marked as selected are read during initialization, so the selection is there from the start.
The sync that runs when a container is realized now only runs when the container and the control disagree. It passes
toggleModifier: true, so without that check it would toggle the selection straight back off the first time the drop-down opened.Fixed issues
Fixes #21571