[Evan260]

What does the pull request do?

Keeps the AutoCompleteBox drop-down open while focus is inside it, so picking an item with the mouse commits the item.

What is the current behavior?

The drop-down is its own popup, so pressing an item moves focus into it. OnLostFocus closes the popup immediately, which means PointerReleased never reaches the selector and the commit never runs. The text box shows the picked item, but focus never returns to it, so a Text binding with UpdateSourceTrigger=LostFocus is left holding whatever was typed before the click.

Picking with the keyboard works, because focus stays in the text box the whole time.

What is the updated/expected behavior with this PR?

OnLostFocus ignores focus moving into the drop-down, so the popup stays open until the item is committed. Items keep their normal focus behaviour and pointer handling is untouched.

Checklist

• Added unit tests (if possible)?
• Added XML documentation to any related classes?
• Consider submitting a PR to https://github.com/AvaloniaUI/avalonia-docs with user documentation

Fixed issues

Fixes #22246

[github-actions]

NuGet packages

The packages for this pull request have been published (workflow run):

• Version: 12.2.999-cibuild0100620-alpha
• Feed URL: https://nuget-feed-all.avaloniaui.net/v3/index.json

[MrJul]

I don't think this is the right approach.

For comparison, ComboBox items are focusable, and we should keep the same behavior here. I'm also worried about the impact on accessibility and automation, but I haven't tested them yet.

This PR introduces a real regression: touch/pen don't close the box anymore. This seems to be actually a pre-existing bug that was previously hidden by the focus change, so in the end it worked.

In addition, if there's any focusable control in the container itself from an item template (a niche scenario, I admit), the fix won't work. We need a more general solution here.

[Evan260]

Sure, I changed the approach. The real problem was that OnLostFocus closed the popup on pointer down, so PointerReleased never reached the selector and the commit never ran, which is why the text never made it to the source. OnLostFocus now ignores focus moving into the drop-down itself, so items stay focusable and nothing about pointer handling changes.