Repository navigation
Fix StreamGeometry Clone and Open when a Transform is set - #22303
Merged
MrJul merged 5 commits intoOct 7, 2026
Merged
Conversation
NuGet packagesThe packages for this pull request have been published (workflow run):
|
MrJul
added
bug
backport-candidate-12.1.x
MrJul
added a commit
to MrJul/Avalonia
that referenced
this pull request
Oct 6, 2026
MrJul
requested changes
Oct 6, 2026
MrJul
left a comment
MrJul
left a comment
Member
There was a problem hiding this comment.
There are some issues with this PR, see the comments.
Member
|
The added render tests are nice! I've added them to #22247, which is imo a proper solution to the issue but requires heavier changes. Meanwhile, we can merge this PR (once issues are resolved). |
MrJul
requested changes
Oct 6, 2026
MrJul
pushed a commit
that referenced
this pull request
Oct 9, 2026
* Add render tests for StreamGeometry Clone and Open with a Transform * Fix StreamGeometry Clone and Open when a Transform is set * Add tests for when a geometry reports that its drawing changed * Report the change when the drawing finishes, and let PathGeometry.Open add figures * Remove the comments and revert the interface type
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Another go at #22213, which was reverted in #22294 because it broke the color picker icons.
Once a geometry has a
Transform,Clone()andOpen()don't get the object they expect, so they threw. The first attempt got around that by using a private field, butPathGeometrynever draws that field, so cloning one gave back an empty shape and the icons came out blank.This one takes the geometry back out of the transform wrapper instead, so
PathGeometrykeeps working.Clone()also keeps theTransform, asGeometryGroupandPolylineGeometrydo.Render tests
Four now. Two fail on main, and two fail on the reverted commit, including a stretched
PathGeometrylike the color picker icons. Those last two are what was missing last time.Fixed issues
Fixes #21494