Repository navigation
Conversation
NuGet packagesThe packages for this pull request have been published (workflow run):
|
MrJul
added
bug
area-textprocessing
backport-candidate-12.1.x
Gillibald
requested changes
Sep 30, 2026
Append only set HasEmbeddings and HasIsolates if they had no value, but Reset sets them to false. Once a BidiData had been reset, explicit formatting characters could no longer raise them, so overrides, embeddings and isolates were only applied only applied in the first paragraph formatted on a thread. HasBrackets is reset the same way, this makes the flags match.
George-Payne
force-pushed
the
fix-bidi-explicit-formatting-after-reset
branch
from
September 30, 2026 11:16
99eb6a0 to
95c052f
Compare
Gillibald
approved these changes
Sep 30, 2026
Gillibald
left a comment
Gillibald
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this contribution
Gillibald
enabled auto-merge
October 5, 2026 08:57
grokys
pushed a commit
to Evan260/Avalonia
that referenced
this pull request
Oct 7, 2026
* Add failing tests for bidi controls being ignored after the first paragraph * Allow embedding and isolate flags to be set after a reset Append only set HasEmbeddings and HasIsolates if they had no value, but Reset sets them to false. Once a BidiData had been reset, explicit formatting characters could no longer raise them, so overrides, embeddings and isolates were only applied only applied in the first paragraph formatted on a thread. HasBrackets is reset the same way, this makes the flags match. * Escape bidi control characters in tests --------- Co-authored-by: Benedikt Stebner <Gillibald@users.noreply.github.com>
MrJul
pushed a commit
that referenced
this pull request
Oct 9, 2026
* Add failing tests for bidi controls being ignored after the first paragraph * Allow embedding and isolate flags to be set after a reset Append only set HasEmbeddings and HasIsolates if they had no value, but Reset sets them to false. Once a BidiData had been reset, explicit formatting characters could no longer raise them, so overrides, embeddings and isolates were only applied only applied in the first paragraph formatted on a thread. HasBrackets is reset the same way, this makes the flags match. * Escape bidi control characters in tests --------- Co-authored-by: Benedikt Stebner <Gillibald@users.noreply.github.com>
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes explicit bidi formatting characters being ignored in every paragraph after the first formatted on a thread.
What is the current behavior?
The first paragraph formatted on a thread resolves them correctly, but every paragraph after it lays out as if they weren't there.
Override: the text should be forced to display right to left.
Isolate: The isolate should stop the name from pulling the number that follows it into its right-to-left run.
What is the updated/expected behavior with this PR?
Explicit formatting characters now apply correctly after a reset.
How was the solution implemented (if it's not obvious)?
HasEmbeddingsandHasIsolatesare now allowed to be set even if they are set tofalseby a reset (matchingHasBrackets).Checklist