Repository navigation
Implement TopLevel.OpenedPopups - #22074
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
How does this take into account Flyouts? |
Member
Author
|
@robloo current flyouts are implemented with Popups, as well as ToolTips. This new API will return backing popups for both of them. |
kekekeks
previously approved these changes
Aug 26, 2026
|
You can test this PR using the following package version. |
MrJul
approved these changes
Aug 26, 2026
kekekeks
pushed a commit
that referenced
this pull request
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR adds new API to access Popups opened on the specific TopLevel target.
public class TopLevel { + IReadOnlyList<Popup> OpenedPopups { get; } } public class Popup { + IReadOnlyList<Popup> OpenedPopups { get; } } public class static HeadlessWindowExtensions { - public static IReadOnlyList<TopLevel> GetOpenPopups(this TopLevel topLevel); }Important implementation details to mention:
Window.OwnedWindowsproperty.Popup.IsOpenPropertycallbacks are recommended.Popup, unlikely removed API from #21889 that returned list of top levels. List of top levels is not applicable with overlay popups, and it's generally confusing to getTopLevelwhen you ask forPopups. But at the same time Popup is a bit less useful in headless testing, so it now requires an extra helper to resolve top level from a popup (if present).Checklist
Breaking changes
Breaking change between nightly builds - removed API.
Fixed issues
Fixes #8403
And replaces new API from #21889