Repository navigation
Propagate Popup.IsHitTestVisible to IPopupImpl to skip hit-testing popups on the OS level if available - #21916
Merged
Merged
Conversation
…pups on the OS level if available
kekekeks
commented
Aug 3, 2026
| /// </summary> | ||
| static Popup() | ||
| { | ||
| IsHitTestVisibleProperty.OverrideDefaultValue<Popup>(false); |
Member
Author
There was a problem hiding this comment.
Note that it was an old hack from 2016 to prevent ImmediateRenderer from hit-testing on Popup itself (which has no content of its own in the host tree, but still counted as control with width and height.
Member
|
Assuming this is a backport candidate for XPF, do we want to make IsHitTestVisible set to true by default on ToolTips with 12.2+ (without backporting)? |
Member
Author
|
I think it makes sense to enable it for tooltips, yes. In a separate PR though |
kekekeks
added
the
backport-candidate-11.3.x
MrJul
added
the
backport-candidate-12.1.x
MrJul
approved these changes
Aug 3, 2026
MrJul
enabled auto-merge
August 3, 2026 17:44
|
You can test this PR using the following package version. |
MrJul
pushed a commit
that referenced
this pull request
Aug 5, 2026
…pups on the OS level if available (#21916) * Propagate Popup.IsHitTestVisible to IPopupImpl to skip hit-testing popups on the OS level if available * I hate our api diff system
MrJul
added
backported-11.3.x
and removed
backport-candidate-11.3.x
MrJul
pushed a commit
to MrJul/Avalonia
that referenced
this pull request
Sep 2, 2026
…pups on the OS level if available (AvaloniaUI#21916) * Propagate Popup.IsHitTestVisible to IPopupImpl to skip hit-testing popups on the OS level if available * I hate our api diff system
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Win32: return HTTRANSPARENT. Opted out of using WS_EX_TRANSPARENT because it will be a can of worms with our zoo of presentation methods
macOS: NSWindow conveniently has setIgnoresMouseEvents
X11/Wayland: empty input region
Why not enable it for Window as well - not sure how well it will play with decorations, especially with macos that removes hit-testing on the whole NSWndow