Repository navigation
Fix: TalkBack should highlight controls instead of their ancestors - #21654
Merged
Merged
Conversation
|
You can test this PR using the following package version. |
IsaMorphic
marked this pull request as draft
June 26, 2026 19:03
IsaMorphic
changed the title
IsaMorphic
changed the title
IsaMorphic
marked this pull request as ready for review
June 26, 2026 19:56
|
You can test this PR using the following package version. |
MrJul
added
bug
os-android
area-accessibility
backport-candidate-12.0.x
MrJul
enabled auto-merge
July 3, 2026 08:03
MrJul
added this pull request to the merge queue
Jul 3, 2026
|
You can test this PR using the following package version. |
MrJul
removed
the
backport-candidate-12.0.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes a regression in the Android TalkBack feature which causes certain controls to become unresponsive to touch exploration, even though they are navigable otherwise. The regression is due to an internal Avalonia API update to the
Visual.FindAncestorOfType(bool)method which ignores the calling instance by default (i.e.includeSelf: false).What is the current behavior?
The current behavior is for Avalonia to find the nearest ancestor for a given
Visualinstance when hovered over by the user. This is incorrect.What is the updated/expected behavior with this PR?
The expected / correct behavior is for Avalonia to give the nearest ancestor for the given
Visual, or, if that instance is a validControl, return a reference to it, instead. Additionally, some exceptions are made for non-container controls which are parents of leaf controls. In these cases, a reference to those parents is returned instead of the leaf.Checklist