Repository navigation
Android - Use BCL storage api for TryGet api - #21641
Merged
Merged
Conversation
|
You can test this PR using the following package version. |
MrJul
approved these changes
Jun 24, 2026
MrJul
left a comment
MrJul
left a comment
Member
There was a problem hiding this comment.
Tested, works as expected: files in the app's folder can be accessed directly via the 3 APIs.
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Changes
IStorageProvider.TryGetFileFromPathAsync,TryGetFolderFromPathAsyncandTryGetWellKnownFolderAsyncto returnBCLStorageItemfor paths passed to them.From Android API 19, which is lower than our minimum supported API 24, apps access storage using the Storage Access Framework (SAF) and do not need permission for read and write access. File managers can still use Java File apis with the older permissions until API 29, from this point, they have to declare a special
MANAGE_EXTERNAL_STORAGEpermission. Arbitrary File access is no longer available to normal apps.With these changes, it makes sense to treat direct file URIs as normal Java Files and require the dev to manage permissions and ensure the URI is valid. We return
BCLStorageItemsfor these apis.What is the current behavior?
IStorageProvider.TryGetFileFromPathAsync,TryGetFolderFromPathAsyncandTryGetWellKnownFolderAsyncreturnsAndroidStorageItemwhich will fail to be read, as these use invalid URIs.What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #21629