Repository navigation
Remove dead code in AvaloniaObject. - #21452
Merged
Merged
Conversation
No implementation of `BindingBase` implements `IObservable<T>` any more, so the `TryBindStyledPropertyUntyped` and `TryBindDirectPropertyUntyped` methods always returned null. Remove them, and move the `IsReadOnly` check into a separate method in the spirit of extracting non-generic code from frequently used generic types.
kekekeks
approved these changes
May 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes obsolete BindingBase handling paths from AvaloniaObject binding overloads and consolidates read-only direct property validation into a shared helper.
Changes:
- Removed dead untyped binding helper methods for styled and direct properties.
- Simplified observable binding paths to call
_values.AddBindingdirectly. - Extracted repeated direct-property
IsReadOnlychecks intoThrowIfReadOnly.
MrJul
enabled auto-merge
May 28, 2026 14:36
|
You can test this PR using the following package version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Removes some old dead code from
AvaloniaObject:No implementation of
BindingBaseimplementsIObservable<T>any more, so theTryBindStyledPropertyUntypedandTryBindDirectPropertyUntypedmethods always returned null.Remove them, and move the
IsReadOnlycheck into a separate method in the spirit of extracting non-generic code from frequently used generic types.