Repository navigation
Pass original logical size to render targets - #21380
Merged
MrJul merged 3 commits intoMay 18, 2026
Merged
Conversation
MrJul
reviewed
May 18, 2026
MrJul
requested changes
May 18, 2026
MrJul
reviewed
May 18, 2026
kekekeks
force-pushed
the
feature/wd/pass-original-logical-size-to-render-targets
branch
from
May 18, 2026 12:49
cd6b6a8 to
9439cb3
Compare
|
You can test this PR using the following package version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves logical->physical size computation of CompositionTarget to the render thread. Original logical size the scene was rendered for is needed for Wayland.
No noticeable impact otherwise, just move from CompositingRenderer to ServerCompositionTarget, UI thread operates with logical size.