Repository navigation
types(schema): treat Int32 paths as number - #16565
Merged
vkarpov15 merged 2 commits intoOct 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
π’ Approval recommended
The implementation is correct, with only minor missing coverage for the lowercase alias.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates Int32 schema definitions so TypeScript consistently treats Int32 paths as JavaScript numbers.
Changes:
- Adds Int32 constructors, instances, and string aliases to
NumberSchemaDefinition. - Adds compile-time coverage for typed, inferred, lean, and raw documents.
| File | Description |
|---|---|
types/βindex.d.ts |
Classifies Int32 schema definitions as numeric. |
test/βtypes/βschema.test.ts |
Verifies Int32 type inference. |
π‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fix #16564
Schema.Types.Int32casts to a plain JS number at runtime, butNumberSchemaDefinitiondidn't include it. So aSchema<{ priority: number }>rejectedtype: Schema.Types.Int32, and inference fell through to thetypeof SchemaTypebranch and typed the path as aSchema.Types.Int32instance. This addsSchema.Types.Int32(and the'int32'/'Int32'strings, which mongoose also accepts) toNumberSchemaDefinition, so those paths are typed asnumbereverywhere number paths are.Examples