Skip to content

Simplify MatcherApplicationStrategy - #2803

Merged
TimvdLippe merged 1 commit into
mockito:mainfrom
big-andy-coates:refactory
Nov 28, 2022
Merged

TimvdLippe merged 1 commit into
mockito:mainfrom
big-andy-coates:refactory

Conversation

@big-andy-coates

@big-andy-coates big-andy-coates commented Nov 28, 2022 •

Copy link
Copy Markdown
Contributor

Prep work for #2796

The class is overly complex, with the precomputed matchingType adding no value.

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

Prep work for mockito#2796

The class is overly complex, with the precomputed `matchingType` adding to value.
@big-andy-coates

Copy link
Copy Markdown
Contributor Author

As discussed @TimvdLippe

#2797 (comment)

@TimvdLippe TimvdLippe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TimvdLippe
TimvdLippe merged commit 8f4af18 into mockito:main Nov 28, 2022
@big-andy-coates
big-andy-coates deleted the refactory branch November 28, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants