Skip to content

RequireSameVersions rule: consider entries in <plugins> when analyzing build- and report-plugins - #892

Merged
slawekjaranowski merged 4 commits into
apache:masterfrom
turing85:bugfix/require-same-versions-plugins
Jun 22, 2025
Merged

slawekjaranowski merged 4 commits into
apache:masterfrom
turing85:bugfix/require-same-versions-plugins

Conversation

@turing85

Copy link
Copy Markdown
Contributor

Resolves #372

RequireSameVersion rule

if plugins are analyzed, entries under <plugins> must be considered f
Following this checklist to help us incorporate your
contribution quickly and easily:

@turing85 turing85 changed the title Bugfix/require same versions plugins RequireSameVersion plugin: consider entries in <plugins> when analyzing build- and report-plugins Jun 22, 2025
@turing85 turing85 changed the title RequireSameVersion plugin: consider entries in <plugins> when analyzing build- and report-plugins RequireSameVersions rule: consider entries in <plugins> when analyzing build- and report-plugins Jun 22, 2025
@turing85
turing85 force-pushed the bugfix/require-same-versions-plugins branch from f6c7fe3 to 37c85cc Compare June 22, 2025 08:37
@slawekjaranowski slawekjaranowski added the bug Something isn't working label Jun 22, 2025
@turing85

Copy link
Copy Markdown
Contributor Author

@slawekjaranowski I'd like to force-push one more time when the pipeline is green. I introduced the formatting error, and I would like to correct this properly.

@turing85
turing85 force-pushed the bugfix/require-same-versions-plugins branch 2 times, most recently from f41b292 to d5a3070 Compare June 22, 2025 09:16
@turing85

Copy link
Copy Markdown
Contributor Author

@slawekjaranowski Done. I think the PR is ready to be merged now πŸ™‚

@turing85
turing85 force-pushed the bugfix/require-same-versions-plugins branch from d5a3070 to fcc96c4 Compare June 22, 2025 09:30
@slawekjaranowski

Copy link
Copy Markdown
Member

there are also an ITs

  • require-same-versions_failure
  • require-same-versions_success

we can check it also, and add assertions in require-same-versions_failure

@slawekjaranowski

Copy link
Copy Markdown
Member

there are also an ITs

  • require-same-versions_failure
  • require-same-versions_success

we can check it also, and add assertions in require-same-versions_failure

I will add it

@turing85

Copy link
Copy Markdown
Contributor Author

there are also an ITs

  • require-same-versions_failure
  • require-same-versions_success

we can check it also, and add assertions in require-same-versions_failure

Where exactly are those ITs? I suggest that we create a separate issue for this.

@slawekjaranowski

Copy link
Copy Markdown
Member

Where exactly are those ITs? I suggest that we create a separate issue for this.

ITs are in maven-enforcer-plugin/src/it/projects

I added simple verification to this PR ... as required this change, and confirms that is ok

@slawekjaranowski
slawekjaranowski force-pushed the bugfix/require-same-versions-plugins branch from 3cf611c to 664805c Compare June 22, 2025 10:04
@slawekjaranowski slawekjaranowski added this to the 3.6.0 milestone Jun 22, 2025
@slawekjaranowski
slawekjaranowski merged commit e8cc57e into apache:master Jun 22, 2025
@slawekjaranowski

Copy link
Copy Markdown
Member

@turing85 thanks

@turing85

Copy link
Copy Markdown
Contributor Author

@turing85 thanks

You are welcome and thanks for the quick merge πŸ₯³

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RequireSameVersion: <plugins> not working

2 participants