Skip to content

fix(logs): coloured logs - #465

Merged
luketomlinson merged 5 commits into
actions:mainfrom
C0ZEN:fix/coloured-logs
Jun 2, 2021
Merged

luketomlinson merged 5 commits into
actions:mainfrom
C0ZEN:fix/coloured-logs

Conversation

@C0ZEN

@C0ZEN C0ZEN commented May 25, 2021 •

Copy link
Copy Markdown
Contributor

Changes

Fixes #459

@C0ZEN
C0ZEN marked this pull request as ready for review May 25, 2021 18:13
@C0ZEN
C0ZEN requested a review from a team as a code owner May 25, 2021 18:13
C0ZEN added 4 commits May 25, 2021 20:18
I was not able to disable or mock ansi-styles so instead I found a way to make the tests pass
it's not perfect but it's still nice because the logs will keep their trustful colour when running through the tests
@C0ZEN
C0ZEN force-pushed the fix/coloured-logs branch from 57a1997 to 57cc23b Compare May 25, 2021 18:20
@C0ZEN

C0ZEN commented Jun 1, 2021 •

Copy link
Copy Markdown
Contributor Author

@luketomlinson would be nice if you could merge this one

@luketomlinson luketomlinson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 Nice work!

@luketomlinson
luketomlinson merged commit 5fbbfba into actions:main Jun 2, 2021
@C0ZEN
C0ZEN deleted the fix/coloured-logs branch June 27, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub logs not coloured

2 participants