Page MenuHomePhabricator

Improve handling of image limits by fixing the UX on pages where these limits are hit
Open, Needs TriagePublic

Description

First reported on mw:Parsoid/Feedback.

Compare Parsoid vs legacy.

As part of the task, let us revisit the following:

  • should we change the limits to something a bit higher?
  • can we ensure that the top N images are rendered vs. some N images on the page?
  • Per @stjn, is there a better UX for flagging these limits to the user (instead of incorrectly rendering them as red links)?

Plan of action

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Isabelle Hurbain-Palatinmediawiki/vendormaster+246 -3 K
OSlegermediawiki/services/parsoidmaster+63 -51
OSlegermediawiki/coremaster+16 -9
OSlegermediawiki/coremaster+11 -3
Subramanya Sastrymediawiki/vendormaster+3 K -3 K
OSlegermediawiki/services/parsoidmaster+1 -1
OSlegermediawiki/services/parsoidmaster+68 -5
OSlegeroperations/mediawiki-configmaster+1 -1
OSlegermediawiki/coremaster+43 -0
Arlolramediawiki/vendormaster+78 -164
Arlolramediawiki/vendorwmf/1.47.0-wmf.11+80 -53
OSlegermediawiki/vendormaster+80 -53
OSlegermediawiki/services/parsoidmaster+15 -3
OSlegermediawiki/coremaster+6 -0
OSlegermediawiki/coremaster+6 -0
Arlolramediawiki/services/parsoidmaster+1 -1
Arlolraoperations/mediawiki-configmaster+3 -0
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

@stjn, I am responding to the user-notice tag, how should I word this for Tech/News?

Something like:

On Parsoid wikis, there is a new limit to the number of images displayed on a page. Initially it was 1000, now it is 1250. The reason is that Parsoid fails to render pages with too much images [ask the team for clarification?]. You can provide feedback in [[phab:T430854]].

While we work on adding a tracking category, a quarry can be useful, select il_from, count(*) as counts from imagelinks group by il_from having counts > 1250 order by counts desc; yields 236 rows on enwiki

https://quarry.wmcloud.org/query/107136

Thanks for the SQL query. I have forked it for dewiki and extended it so that the page title gets displayed directly:
https://quarry.wmcloud.org/query/107150

So this means we currently have 134 pages on dewiki where the limit gets hit.

Looks like the page in enwiki's main namespace with the highest number of unique images is https://en.wikipedia.org/wiki/Armorial_of_Russia with 2888. (https://quarry.wmcloud.org/query/107149). Pages in the user and project namespaces are of much lesser concern.

This does kind of beg the question, though - is the limit in Parsoid the number of unique images, or the total including duplicates? Database queries can't help with the latter.

This does kind of beg the question, though - is the limit in Parsoid the number of unique images, or the total including duplicates? Database queries can't help with the latter.

Unique images (well, keyed to the title, dimension, format, and other media options that affect the thumbnail rendering)

See the test case in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1275427/14/tests/parser/media.txt where the repeated file is only counted once [[File:Foobar.jpg| one ]] ... [[File:Foobar.jpg| four ]]

Something like:

On Parsoid wikis, there is a new limit to the number of images displayed on a page. Initially it was 1000, now it is 1250. The reason is that Parsoid fails to render pages with too much images [ask the team for clarification?]. You can provide feedback in [[phab:T430854]].

@STei-WMF: "On Parsoid-enabled wikis, Parsoid renders a maximum of 1250 images on a page. See [[phab:T430854]] for more details and to provide feedback." I think this may be simple enough and interested folks can come here for more details and discussion.

Is there a reason why only the first 1,186 files linked from https://en.wikipedia.org/w/index.php?title=Armorial_of_Russia are actually displayed (only those up to