Page MenuHomePhabricator
Differential D315356

Bug 1940906 - Add IsModelInstalled to the model install IPC. r?#ipc-reviewers
ClosedPublic
Actions

Authored by padenot on Jul 30 2026, 5:09 PM.
Tags
Referenced Files
Unknown Object (File)
Mon, Nov 9, 3:52 AM
Unknown Object (File)
Thu, Oct 29, 7:23 PM
Unknown Object (File)
Tue, Oct 27, 10:28 AM
Unknown Object (File)
Wed, Oct 21, 7:10 AM
Unknown Object (File)
Wed, Oct 21, 7:01 AM
Unknown Object (File)
Tue, Oct 20, 10:24 AM
Unknown Object (File)
Tue, Oct 20, 6:17 AM
Unknown Object (File)
Tue, Oct 20, 12:02 AM
View All 82 Files
Subscribers
reviewbot

Details

Reviewers
alwu
Group Reviewers
ipc-reviewers
media-playback-reviewers
Commits
rFIREFOXAUTOLAND3031ea1b4b91: Bug 1940906 - Add IsModelInstalled to the model install IPC. r=media-playback…
Bugzilla Bug ID
1940906

Diff Detail

Event Timeline

padenot created this revision.Jul 30 2026, 5:09 PM
Herald added a project: secure-revision. · View Herald TranscriptJul 30 2026, 5:09 PM
phab-bot published this revision for review.Jul 30 2026, 5:10 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a reviewer: media-playback-reviewers. · View Herald TranscriptJul 30 2026, 5:10 PM
padenot added a child revision: D311113: Bug 1940906 - Show a permission prompt before downloading the speech recognition model. r?jib.Jul 30 2026, 5:12 PM
Harbormaster failed remote builds in B1013957: Diff 1335738!Jul 30 2026, 5:12 PM
alwu accepted this revision.Jul 30 2026, 5:40 PM
This revision is now accepted and ready to land.Jul 30 2026, 5:40 PM
Herald added a project: needs-testing-tag. · View Herald TranscriptJul 30 2026, 5:40 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

padenot updated this revision to Diff 1336912.Jul 31 2026, 5:37 PM
Harbormaster failed remote builds in B1014824: Diff 1336912!Jul 31 2026, 5:51 PM
padenot updated this revision to Diff 1338105.Aug 3 2026, 4:53 PM
Harbormaster failed remote builds in B1015703: Diff 1338105!Aug 3 2026, 5:05 PM
padenot updated this revision to Diff 1339183.Aug 4 2026, 6:05 PM
Harbormaster failed remote builds in B1016472: Diff 1339183!Aug 4 2026, 6:18 PM
padenot updated this revision to Diff 1345104.Aug 11 2026, 5:46 PM
Harbormaster failed remote builds in B1020814: Diff 1345104!Aug 11 2026, 5:58 PM
padenot updated this revision to Diff 1346292.Aug 12 2026, 7:05 PM
Harbormaster failed remote builds in B1021742: Diff 1346292!Aug 12 2026, 7:19 PM
padenot updated this revision to Diff 1347372.Aug 13 2026, 4:18 PM
padenot retitled this revision from Bug 1940906 - Add IsModelInstalled and GetModelDownloadSize to the model install IPC. r?#ipc-reviewers to Bug 1940906 - Add IsModelInstalled to the model install IPC. r?#ipc-reviewers.
Harbormaster failed remote builds in B1022659: Diff 1347372!Aug 13 2026, 4:31 PM
padenot updated this revision to Diff 1349962.Aug 17 2026, 4:33 PM
Harbormaster failed remote builds in B1024542: Diff 1349962!Aug 17 2026, 4:45 PM
padenot updated this revision to Diff 1351244.Aug 18 2026, 4:17 PM
reviewbot added a subscriber: reviewbot.Aug 18 2026, 5:02 PM

Code analysis found 42 defects in diff 1351244:

  • 42 build errors found by clang-tidy
IMPORTANT: Found 42 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)
NOTE: Tasks were added or removed in diff 1351244.

The following parameter sets have differences:

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1351244.

Harbormaster failed remote builds in B1025473: Diff 1351244!Aug 18 2026, 5:02 PM
padenot updated this revision to Diff 1358082.Aug 25 2026, 6:58 PM
padenot removed a parent revision: D315355: Bug 1940906 - Register a speech-recognition nsIMLModelResolver. r?#ipc-reviewers.Aug 25 2026, 7:02 PM
padenot added a parent revision: D311112: Bug 1940906 - Select the speech recognition model per locale. r?#media-playback-reviewers.
padenot removed a child revision: D311113: Bug 1940906 - Show a permission prompt before downloading the speech recognition model. r?jib.Aug 25 2026, 7:03 PM
padenot removed a parent revision: D311112: Bug 1940906 - Select the speech recognition model per locale. r?#media-playback-reviewers.
padenot added a child revision: D275653: Bug 1940906 - Introduce SpeechRecognitionBackend - Part 1 - Static methods. r?nika.Aug 25 2026, 7:04 PM
padenot removed a child revision: D275653: Bug 1940906 - Introduce SpeechRecognitionBackend - Part 1 - Static methods. r?nika.Aug 25 2026, 7:06 PM
padenot added a parent revision: D311112: Bug 1940906 - Select the speech recognition model per locale. r?#media-playback-reviewers.Aug 25 2026, 7:07 PM
padenot added a child revision: D275653: Bug 1940906 - Introduce SpeechRecognitionBackend - Part 1 - Static methods. r?nika.
Harbormaster failed remote builds in B1030371: Diff 1358082!Aug 25 2026, 7:13 PM
padenot updated this revision to Diff 1361669.Aug 31 2026, 4:49 PM
reviewbot added a comment.Aug 31 2026, 5:48 PM

Code analysis found 5 defects in diff 1361669:

  • 5 build errors found by clang-tidy
IMPORTANT: Found 5 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1361669.

Harbormaster failed remote builds in B1033004: Diff 1361669!Aug 31 2026, 5:48 PM
padenot updated this revision to Diff 1362735.Sep 1 2026, 2:27 PM
reviewbot added a comment.Sep 1 2026, 3:35 PM

The analysis task source-test-mozlint-py-ruff-format failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-eslint failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-test-manifest failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-yaml failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-mscom-init failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-header-guards failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-node-devtools-tests failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-clang-tidy failed, but we could not detect any defect.
Please check this task manually.

If you see a problem in this automated review, please report it here.

Harbormaster failed remote builds in B1033805: Diff 1362735!Sep 1 2026, 3:35 PM
padenot updated this revision to Diff 1363694.Sep 2 2026, 10:11 AM
padenot updated this revision to Diff 1363805.Sep 2 2026, 12:23 PM
This revision was landed with ongoing or failed builds.Sep 2 2026, 12:31 PM
Closed by commit rFIREFOXAUTOLAND3031ea1b4b91: Bug 1940906 - Add IsModelInstalled to the model install IPC. r=media-playback… (authored by padenot). · Explain Why
This revision was automatically updated to reflect the committed changes.
padenot added a commit: rFIREFOXAUTOLAND3031ea1b4b91: Bug 1940906 - Add IsModelInstalled to the model install IPC. r=media-playback….
Harbormaster failed remote builds in B1034663: Diff 1363805!Sep 2 2026, 1:02 PM
padenot mentioned this in rFIREFOXBETA3031ea1b4b91: Bug 1940906 - Add IsModelInstalled to the model install IPC. r=media-playback….Sep 10 2026, 11:37 AM
padenot mentioned this in rFIREFOXRELEASE3031ea1b4b91: Bug 1940906 - Add IsModelInstalled to the model install IPC. r=media-playback….Sep 24 2026, 7:17 AM

Revision Contents
Changeset List
Float

PathSize
dom/
media/
webspeech/
recognition/
3 lines
11 lines
22 lines

Diff 1363858

View Options

dom/media/webspeech/recognition/PSpeechRecognition.ipdl

Loading...
View Options

dom/media/webspeech/recognition/SpeechRecognitionParent.h

Loading...
View Options

dom/media/webspeech/recognition/SpeechRecognitionParent.cpp

Loading...
Privacy · Cookies · Legal