Page MenuHomePhabricator

Bug 1940906 - Add the unspokenPunctuation attribute to SpeechRecognition. r?#media-playback-reviewers
ClosedPublic

Authored by padenot on Jul 8 2026, 5:06 PM.
Referenced Files
Unknown Object (File)
Tue, Oct 20, 3:02 PM
Unknown Object (File)
Sat, Oct 17, 10:23 PM
Unknown Object (File)
Sep 29 2026, 7:27 AM
Unknown Object (File)
Sep 29 2026, 3:33 AM
Unknown Object (File)
Sep 29 2026, 3:05 AM
Unknown Object (File)
Sep 28 2026, 11:12 PM
Unknown Object (File)
Sep 28 2026, 10:59 PM
Unknown Object (File)
Sep 28 2026, 10:31 PM
Subscribers

Details

Summary

Per spec, unspokenPunctuation defaults to false; the value is stored for
round-tripping but does not change recognition behaviour, since Gecko's
recognizer is LLM-based and only infers punctuation that was not spoken.

Spec: https://webaudio.github.io/web-speech-api/#dom-speechrecognition-unspokenpunctuation
WPT: covered by interfaces/speech-api.idl via idlharness.

Diff Detail

Event Timeline

phab-bot published this revision for review.Jul 8 2026, 5:07 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
alwu added a subscriber: alwu.

Please add https://webaudio.github.io/web-speech-api/#dom-speechrecognition-unspokenpunctuation in the commit message, and I assume wpt covers this attribute already?

dom/media/webspeech/recognition/SpeechRecognition.cpp
396

Log?

This revision is now accepted and ready to land.Jul 8 2026, 9:49 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

padenot added inline comments.
dom/media/webspeech/recognition/SpeechRecognition.cpp
396

This is no-op for now, maybe if/when we do something.

padenot edited the summary of this revision. (Show Details)
padenot marked an inline comment as done.

Code analysis found 10 defects in diff 1361691:

  • 10 build errors found by clang-tidy
IMPORTANT: Found 10 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)
NOTE: Tasks were added or removed in diff 1361691.

The following parameter sets have differences:


If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1361691.

The analysis task source-test-mozlint-clang-format failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-doc-upload failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-stylelint failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-wpt-subsuite-tagging failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-updatebot failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-trojan-source failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-file-perm failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-license failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-c-includes failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-perfdocs-verify failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-dot-mozilla-reference failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-clang-tidy failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-header-guards failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-rejected-words failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-clang-external failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-yaml failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-file-whitespace failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-codespell failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-eslint failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-py-ruff failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-fluent-lint failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-mingw-cap failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-py-ruff-format failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-md failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-taskgraph-diff failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-test-manifest failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-mscom-init failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-node-devtools-verify-bundle failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-lintpref failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-node-devtools-tests failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-l10n-conflicts failed, but we could not detect any defect.
Please check this task manually.


If you see a problem in this automated review, please report it here.

Code analysis found 1 defect in diff 1363720:

  • 1 build error found by clang-tidy
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-mozlint-fluent-lint failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-updatebot failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-node-devtools-tests failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-clang-format failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-codespell failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-dot-mozilla-reference failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-wptlint-gecko failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-py-ruff-format failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-mscom-init failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-doc-upload failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-file-whitespace failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-header-guards failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-mozlint-wpt-subsuite-tagging failed, but we could not detect any defect.
Please check this task manually.

NOTE: Tasks were added or removed in diff 1363720.

The following parameter sets have differences:


If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1363720.