Differential D311103
Bug 1940906 - Stream audio in smaller blocks; implement chunked downmixing. r?#media-playback-reviewers Authored by padenot on Jul 8 2026, 5:04 PM. Tags Referenced Files
Details
Send audio to the inference process in ~40ms blocks instead of 0.5s, so Count the amount of frame dropped, increase ringbuffer depth to smooth
Diff Detail
Event TimelineComment Actions This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy! Comment Actions I'll find stereo speech for testing, good call. I think it's all mono for now in my tests. Comment Actions No, better than landing a stereo file, I just upmixed with the Web Audio API, so this is covered. Comment Actions Code analysis found 42 defects in diff 1351234:
IMPORTANT: Found 42 defects (error level) that must be fixed before landing.
You can run this analysis locally with:
If you see a problem in this automated review, please report it here. You can view these defects in the Diff Detail section of Phabricator diff 1351234. Comment Actions Code analysis found 11 defects in diff 1361675:
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 10 defects (error level) that must be fixed before landing.
You can run this analysis locally with:
If you see a problem in this automated review, please report it here. You can view these defects in the Diff Detail section of Phabricator diff 1361675. Comment Actions Code analysis found 10 defects in diff 1362742:
IMPORTANT: Found 10 defects (error level) that must be fixed before landing.
You can run this analysis locally with:
The analysis task source-test-mozlint-rejected-words failed, but we could not detect any defect. The analysis task source-test-node-devtools-tests failed, but we could not detect any defect. The analysis task source-test-mozlint-c-includes failed, but we could not detect any defect. The analysis task source-test-mozlint-dot-mozilla-reference failed, but we could not detect any defect. The analysis task source-test-mozlint-eslint failed, but we could not detect any defect. The analysis task source-test-mozlint-clang-format failed, but we could not detect any defect. The analysis task source-test-mozlint-trojan-source failed, but we could not detect any defect. If you see a problem in this automated review, please report it here. You can view these defects in the Diff Detail section of Phabricator diff 1362742. Comment Actions Code analysis found 8 defects in diff 1363702:
IMPORTANT: Found 8 defects (error level) that must be fixed before landing.
You can run this analysis locally with:
The analysis task source-test-mozlint-trojan-source failed, but we could not detect any defect. The analysis task source-test-mozlint-eslint failed, but we could not detect any defect. The analysis task source-test-mozlint-py-ruff failed, but we could not detect any defect. The analysis task source-test-mozlint-rejected-words failed, but we could not detect any defect. The analysis task source-test-mozlint-clang-format failed, but we could not detect any defect. The analysis task source-test-mozlint-mingw-cap failed, but we could not detect any defect. The analysis task source-test-mozlint-file-perm failed, but we could not detect any defect. The analysis task source-test-mozlint-c-includes failed, but we could not detect any defect. The analysis task source-test-doc-upload failed, but we could not detect any defect. The analysis task source-test-node-devtools-tests failed, but we could not detect any defect. The analysis task source-test-mozlint-lintpref failed, but we could not detect any defect. The analysis task source-test-node-devtools-verify-bundle failed, but we could not detect any defect. The analysis task source-test-mozlint-py-ruff-format failed, but we could not detect any defect. If you see a problem in this automated review, please report it here. You can view these defects in the Diff Detail section of Phabricator diff 1363702. |
