Details

Reviewers

mkaply
mossop

Commits

rFIREFOXAUTOLANDeae85737b795: Bug 1996449 - Ensure runOncePerModification("displayMenuBar", ..) works as…
rFIREFOXAUTOLAND0df9ebba38e6: Bug 1996449 - Ensure runOncePerModification("displayMenuBar", ..) works as…

Bugzilla Bug ID

1996449

Summary

runOncePerModification works on strings. If you pass a boolean down it
will always call its callback (because "true" != true etc).

Diff Detail

Repository

rFIREFOXAUTOLAND firefox-autoland

Build Status

Buildable 871815
Build 972735: arc lint + arc unit

Event Timeline

emilio created this revision.Nov 5 2025, 6:20 PM

Herald added a project: secure-revision. · View Herald TranscriptNov 5 2025, 6:20 PM

phab-bot published this revision for review.Nov 5 2025, 6:20 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Harbormaster completed remote builds in B870268: Diff 1150742.Nov 5 2025, 6:35 PM

mossop added a subscriber: mossop.Nov 6 2025, 7:46 AM

mossop added inline comments.

browser/components/enterprisepolicies/Policies.sys.mjs
1164	This seems like a footgun. Can we instead modify `runOncePerModification` to stringify the value before doing the comparison?

emilio added a reviewer: mossop.Nov 6 2025, 10:00 AM

emilio marked an inline comment as done.

emilio added inline comments.

browser/components/enterprisepolicies/Policies.sys.mjs
1164	This seems like a footgun. Can we instead modify `runOncePerModification` to stringify the value before doing the comparison? Sure, in fact at first I thought of that but it was documented to take a `string`... Do you know if we're thinking of adding types to JS long term? It seems like typescript would've caught this.

emilio updated this revision to Diff 1151255.Nov 6 2025, 10:01 AM

emilio marked an inline comment as done.

mossop accepted this revision.Nov 6 2025, 10:05 AM

mossop added 1 blocking reviewer(s): mkaply.

mossop added inline comments.

browser/components/enterprisepolicies/Policies.sys.mjs
1164	Yes we are and in fact I'm delighted to have examples to point to where they would have helped!

Harbormaster completed remote builds in B870660: Diff 1151255.Nov 6 2025, 10:17 AM

mkaply accepted this revision.Nov 7 2025, 6:35 PM

This revision is now accepted and ready to land.Nov 7 2025, 6:35 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!