Details
Diff Detail
- Repository
- rFIREFOXAUTOLAND firefox-autoland
Event Timeline
I didn't add an automated test for this. It didn't feel necessary.
This wasn't a bug, just missed when this feature was first done.
The changes to QuickActions won't happen unless there is a restart. I think that is fine.
| browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs | ||
|---|---|---|
| 333–338 | I think this would probably be better implemented as a isVisible option on the action itself - that way it would be consistent with the rest of the actions. I think we'd then want to add the preference to UrlbarPrefs.PREF_OTHER_DEFAULTS and use the preference from there, @adw is that correct for our standard urlbar code? | |
Yeah, I screwed that up when I did the initial patch. I'll fix (although UI won't update - that's a bug)
| browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs | ||
|---|---|---|
| 333–338 | I completely missed the isVisible. That's definitely the right way to do it; | |
| browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs | ||
|---|---|---|
| 333–338 | IMO it's fine to use Services.prefs directly, especially for a pref that isn't widely accessed in urlbar code, so thumbs up from me. (If you did want to access it via UrlbarPrefs, adding it to that const is the way to do that.) | |
@mkaply I'll skip setting a testing tag since this patch doesn't have one but I don't know if it needs one? Could you set an appropriate one please?
This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!
