🔥 Jadwal & Hasil: zarf dev/zarf/issues/

AustinAbro321 · 2026-11-05T17:46:36Z

Description

The v1.0 release gives us an opportunity to remove deprecated sdk fields.

Removed old state fields. Kept a bridge for reading old agent fields which have been replaced by an AgentInfo struct in v0.85.0, but removed the fields from state.

Added an automatic entry to GitServerMode which was introduced in v0.87.0 (should have already had this).

This also removes compatibility with older packages that have a different format. Packages created in v0.50.0 (March 20, 2025) are no longer compatible. (Crane->Oras annotations).

Removed some exported functions that are unused in Zarf and unlikely to be used by SDK consumers

I missed a few deprecated flags in an earlier PR:

The --output-directory flag on create which was replaced by --output
I originally didn't remove the --signing-key flags from zarf package publish for skeletons, but changed that stance since I realized that they can be signed using zarf package sign

Checklist before merging

Test, docs, adr added or updated as needed
Contributor Guide Steps followed

Signed-off-by: Austin Abro <austinabro321@gmail.com>

netlify · 2026-11-05T17:46:49Z

✅ Deploy Preview for zarf-docs ready!

Name	Link
🔨 Latest commit	`9be0daa`
🔍 Latest deploy log	https://app.netlify.com/projects/zarf-docs/deploys/6aee3c2fdba4fc908b490a57
😎 Deploy Preview	https://deploy-preview-5615--zarf-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Austin Abro <austinabro321@gmail.com>

codecov · 2026-11-05T17:52:05Z

Codecov Report

❌ Patch coverage is 65.11628% with 30 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/cmd/package.go	0.00%	11 Missing ⚠️
src/cmd/viper.go	58.33%	4 Missing and 1 partial ⚠️
src/cmd/dev.go	0.00%	3 Missing ⚠️
src/internal/git/repository.go	0.00%	1 Missing and 1 partial ⚠️
src/pkg/packager/deploy.go	0.00%	2 Missing ⚠️
src/pkg/packager/load/import.go	0.00%	2 Missing ⚠️
src/cmd/connect.go	0.00%	1 Missing ⚠️
src/cmd/zarf_tools.go	50.00%	1 Missing ⚠️
src/pkg/cluster/cluster.go	95.83%	1 Missing ⚠️
src/pkg/packager/assemble/assemble.go	0.00%	0 Missing and 1 partial ⚠️
... and 1 more

Files with missing lines	Coverage Δ
src/cmd/table.go	`76.19% <100.00%> (ø)`
src/internal/agent/operations/patch.go	`100.00% <ø> (+58.62%)`	⬆️
src/internal/packager/template/template.go	`90.80% <ø> (-0.11%)`	⬇️
src/pkg/component/publish.go	`58.02% <100.00%> (ø)`
src/pkg/images/common.go	`62.05% <ø> (+0.88%)`	⬆️
src/pkg/images/push.go	`50.49% <ø> (-0.63%)`	⬇️
src/pkg/logger/logger.go	`55.00% <ø> (ø)`
src/pkg/message/message.go	`93.18% <100.00%> (+3.18%)`	⬆️
src/pkg/packager/create.go	`59.68% <100.00%> (-0.62%)`	⬇️
src/pkg/packager/digest.go	`48.43% <100.00%> (ø)`
... and 23 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Austin Abro <austinabro321@gmail.com>

dwertent

I left a few comments, I hope I didn't miss anything.
The only "blocker" from my pov is the deprecated agentTLS config write

dwertent · 2026-11-06T18:44:01Z

 	}

 	if s != nil {
-		s.Reconcile()


No familiar with the code, but this looks like a behavior change.

A side affect of removing the agentTLS and nodeport fields on state. Now that there are no bridges, there's nothing to reconcile.

dwertent · 2026-11-06T18:48:35Z


 	s := &state.State{}
-	err = json.Unmarshal(secret.Data[state.ZarfStateDataKey], s)
+	// Keep the pre-v0.85 agent fields at the read boundary; saves use only state.State.


I believe there is a good reason not to remove this deprecated part.
Maybe we should comment why it's not being removed now.
Also, for future reference maybe it's worth documenting the deprecated fields, e.g.

// Deprecated: AgentInfo is deprecated as of v0.85 and will be removed in a future release. // Use state.AgentInfo directly instead. AgentInfo *state.AgentInfo `json:"agentInfo"` // Deprecated: AgentTLS is maintained only for backwards compatibility with pre-v0.85 states. AgentTLS pki.GeneratedPKI `json:"agentTLS"` // Deprecated: AgentTLSUserProvided is no longer used internally. AgentTLSUserProvided bool `json:"agentTLSUserProvided"` // Deprecated: AgentMutationPolicy will be removed in the next major version. AgentMutationPolicy state.MutationPolicy `json:"agentMutationPolicy"`

See this comment:
#5615 (comment)

Essentially my stance here is that if someone upgrades to v1.0, then they shouldn't downgrade back to pre-v1.0 (in this case v0.84.0 which was before we introduced the struct to replace the agent config). This would be consistent with the stance I'm taking in #5619. Open to being more conservative. Curious on @brandtkeller's thoughts on this approach.

Agree - we need to be noisy about v1.0.0 and compatibility - but I would advocate for the same.

dwertent · 2026-11-06T18:49:49Z

+			s.GitServer.GitServerMode = state.GitServerModeInternal
 		} else {
-			s.RegistryInfo.RegistryMode = state.RegistryModeExternal
+			s.GitServer.GitServerMode = state.GitServerModeExternal


I just want to make sure this change (renaming RegistryInfo to GitServer) is intentional

Yup, essentially we're deleting a bridge that has been around for a long time (for registry info) and adding one for git server info for a field that was introduced, but did not have it.

This lets us decouple the address from whether the git server is internal in case in the future we are to ever change the address.

dwertent · 2026-11-06T18:52:12Z

 // strLevels maps a string to its Level.
 var strLevels = map[string]Level{
-	// NOTE(mkcp): Map trace to debug for backwards compatibility.
-	"trace": Debug,


It's good to see this is removed :)

dwertent · 2026-11-06T18:52:54Z

-		tPrinter.Writer = writer
-	}
-	_ = tPrinter.WithHasHeader().WithData(table).Render() //nolint:errcheck
+	_ = pterm.DefaultTable.WithWriter(writer).WithHasHeader().WithData(table).Render() //nolint:errcheck // Table output is best effort, matching the other message printers.


Thanks for adding the comment

dwertent · 2026-11-06T18:55:11Z

 }

 func (c remoteReferenceCache) load(ctx context.Context, importURL, arch string, remoteOptions types.RemoteOptions, cachePath string) (loadedComponentConfig, error) {
-	remote, err := zoci.NewRemoteWithOptions(ctx, importURL, ocispec.Platform{Architecture: arch}, zoci.RemoteClientOptions{


It's probably too late for this comment, but it's interesting that we didn't create a package for v1beta1 and instead we are just adding that as a suffix to the file name.

It should be doable in the future, the functions regarding the specific v1beta1 import process are private with a few helper exceptions

dwertent · 2026-11-06T19:37:09Z

+
+func (r configDecoderRegistry) Decoder(format string) (viper.Decoder, error) {
+	switch strings.ToLower(format) {
+	case "yaml", "yml", "toml":


I don't think this is needed, if the file has the wrong format, viper will fail and print that the format is not supported.

We are intentionally limiting the formats that we support to yaml and toml whereas by default viper supports things like .env and .json. I did just realize that our help text forzarf dev generate-config is off though.

dwertent · 2026-11-06T19:43:55Z

 	// AgentInfo contains information Zarf uses to configure the agent.
-	AgentInfo AgentInfo `json:"agentInfo"`
-	// Deprecated: Use AgentInfo.TLS instead. Kept for backwards compatibility with state JSON written by older Zarf versions.
-	AgentTLS pki.GeneratedPKI `json:"agentTLS"`


ok, now I see the deprecated agent config.
I think we should leave it here with omitempty and deprecated comment and not add it in the code the way we have (#5615 (comment)).

dwertent · 2026-11-06T19:45:56Z

 		require.Equal(t, expectedIDs[i], component.Name)
 	}

-	// Deprecated signing flags remain compatible with this publish flow.


It looks like we changed the comment but the flags remain the same

We now are signing through zarf package sign instead of zarf package publish (signing through publish is deprecated)

dwertent · 2026-11-06T19:49:29Z


 	var sha string
-	// shas for package published 2023-08-08T22:13:51Z
+	// Digests for dos-games 1.3.0, published January 26, 2026.


nit: A link to the run that published rather than the date.
Future work/suggestion: maybe we should have a WF once a week/month whatever bumping the packages and publishing a new image (and then overriding the image here), this way, users who have CVE related policies in there clusters can install the demo without problems.

The run logs are long expired https://github.com/zarf-dev/zarf/actions/runs/21369659860/job/61510621383 😞

The point of this particular test is to make sure that old Zarf packages work with newer Zarf (hence me having to update this, we actually broke compat with 2023 packages in this PR). But yeah we probably shouldn't use a small user facing example for this test, and instead have a big package that relies on every feature of Zarf so we actually test all the features of the schema / layout.

But yeah a weekly update of our examples would be great, we do not update them nearly enough rn

Signed-off-by: Austin Abro <austinabro321@gmail.com>

brandtkeller

neat to see and well executed - lgtm

AustinAbro321 added 6 commits November 4, 2026 16:26

remove deprecated fields

d78cfda

Signed-off-by: Austin Abro <austinabro321@gmail.com>

remove

1b56687

Signed-off-by: Austin Abro <austinabro321@gmail.com>

deprecated fields

8902c6c

Signed-off-by: Austin Abro <austinabro321@gmail.com>

finish

59f457e

Signed-off-by: Austin Abro <austinabro321@gmail.com>

writer

9b27aaf

Signed-off-by: Austin Abro <austinabro321@gmail.com>

unused functions

782bbcc

Signed-off-by: Austin Abro <austinabro321@gmail.com>

github-project-automation Bot added this to Zarf Nov 5, 2026

merge

c1d3f57

Signed-off-by: Austin Abro <austinabro321@gmail.com>

AustinAbro321 added 3 commits November 5, 2026 13:51

regression

b42af93

Signed-off-by: Austin Abro <austinabro321@gmail.com>

regression

ba6e0ea

Signed-off-by: Austin Abro <austinabro321@gmail.com>

deprecated fields

96a33c2

Signed-off-by: Austin Abro <austinabro321@gmail.com>

AustinAbro321 changed the title ~~feat!: remove deprecated SDK fields~~ feat!: remove deprecated SDK fields and bridges Nov 5, 2026

AustinAbro321 added 4 commits November 5, 2026 14:48

bam

05b8b76

Signed-off-by: Austin Abro <austinabro321@gmail.com>

delete

632175c

Signed-off-by: Austin Abro <austinabro321@gmail.com>

old agent

895a2f6

Signed-off-by: Austin Abro <austinabro321@gmail.com>

unnecessary tests

c140dd5

Signed-off-by: Austin Abro <austinabro321@gmail.com>

AustinAbro321 changed the title ~~feat!: remove deprecated SDK fields and bridges~~ feat!: removed deprecated SDK fields and bridges Nov 5, 2026

AustinAbro321 marked this pull request as ready for review November 5, 2026 20:31

AustinAbro321 requested review from a team as code owners November 5, 2026 20:31

AustinAbro321 added 2 commits November 6, 2026 10:03

fix merge

4a7c3b7

Signed-off-by: Austin Abro <austinabro321@gmail.com>

connectivity

2a51778

Signed-off-by: Austin Abro <austinabro321@gmail.com>

dwertent reviewed Nov 6, 2026

View reviewed changes

generate

9be0daa

Signed-off-by: Austin Abro <austinabro321@gmail.com>

brandtkeller added the v1.0.0 Issues tracking toward Zarf v1.0.0 label Nov 7, 2026

brandtkeller approved these changes Nov 8, 2026

View reviewed changes

brandtkeller added this pull request to the merge queue Nov 8, 2026

Merged via the queue into main with commit 0cf9039 Nov 8, 2026
42 checks passed

brandtkeller deleted the remove-deprecated-fields branch November 8, 2026 03:16

github-project-automation Bot moved this to Done in Zarf Nov 8, 2026

zarf-release-please Bot mentioned this pull request Nov 8, 2026

chore(main): release 1.0.0 #5567

Merged

Conversation

AustinAbro321 commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist before merging

Uh oh!

netlify Bot commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for zarf-docs ready!

Uh oh!

codecov Bot commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dwertent left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dwertent Nov 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AustinAbro321 Nov 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AustinAbro321 Nov 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brandtkeller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AustinAbro321 commented Nov 5, 2026 •

edited

Loading

netlify Bot commented Nov 5, 2026 •

edited

Loading

codecov Bot commented Nov 5, 2026 •

edited

Loading

dwertent Nov 6, 2026 •

edited

Loading

AustinAbro321 Nov 6, 2026 •

edited

Loading

AustinAbro321 Nov 6, 2026 •

edited

Loading